When using PERF_RECORD_SWITCH, allow ContextSwitchEvent initialization to fail
#3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion to fail
The tracee may have died unexpectedly or been killed.
This commit allows the `cont_race` test to consistently pass when the test is run
under all the following conditions:
(a) kernel.perf_event_paranoid = 2
(b) kernel supports PERF_RECORD_SWITCH (Linux kernel >= 6.10)
(c) syscallbuf is enabled (so here we're talking only about `cont_race`
and NOT `cont_race-no-syscallbuf` which doesn't need switch events anyways)
Without this commit, I noticed the occasional failure in (syscallbuf enabled) `cont_race`:
[FATAL src/PerfCounterBuffers.cc:32:allocate() errno: EBADF] Can't allocate memory for PT DATA area
|
(If you look at the code in |
sidkshatriya
changed the title
PERF_RECORD_SWITCH, allow ContextSwitchEvent initializatation to failPERF_RECORD_SWITCH, allow ContextSwitchEvent initialization to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tracee may have died unexpectedly or been killed.
This commit allows the
cont_racetest to consistently pass when the test is run under all the following conditions:(a) kernel.perf_event_paranoid = 2
(b) kernel supports PERF_RECORD_SWITCH (Linux kernel >= 6.10)
(c) syscallbuf is enabled (so here we're talking only about
cont_raceand NOT
cont_race-no-syscallbufwhich doesn't need switch events anyways)Without this commit, I noticed the occasional failure in (syscallbuf enabled)
cont_race: