Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddressSpace::verify() should not be infallible #3873

Merged
merged 1 commit into from
Nov 8, 2024
Merged

AddressSpace::verify() should not be infallible #3873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/AddressSpace.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1757,7 +1757,11 @@ void AddressSpace::verify(Task* t) const {
LOG(debug) << "Verifying address space for task " << t->tid;

MemoryMap::const_iterator mem_it = mem.begin();
KernelMapIterator kernel_it(t);
bool ok = false;
// Must pass ok parameter otherwise KernelMapIterator constructor will become
// infallible if /proc/[tid]/maps cannot be opened
KernelMapIterator kernel_it(t, &ok);
// checking at_end() is equivalent to checking if ok
if (kernel_it.at_end()) {
LOG(debug) << "Task " << t->tid << " exited unexpectedly, ignoring";
return;
Expand Down