-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build a Nupkg without a .nuspec #579
Conversation
@jmezach All is good, I was looking in the wrong place 😄 This is an example of the auto generated .nuspec from the test project: <?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
<metadata>
<id>TestProject</id>
<version>2.8.0-beta.29.g04d634525c</version>
<authors>MSBuild.SDK.SqlProj team</authors>
<projectUrl>https://github.com/rr-wfm/MSBuild.Sdk.SqlProj/</projectUrl>
<description>Package Description</description>
<dependencies>
<group targetFramework=".NETStandard2.0" />
</dependencies>
</metadata>
<files>
<file src="C:\Code\Github\MSBuild.Sdk.SqlProj\test\TestProject\bin\Debug\netstandard2.0\TestProject.dacpac" target="tools\TestProject.dacpac" />
</files>
</package>
|
test/TestProjectWithNoNuspecForPacking/TestProjectWithNoNuspecForPacking.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jmezach Curious how this worked before? https://github.com/rr-wfm/MSBuild.Sdk.SqlProj/blob/master/src/MSBuild.Sdk.SqlProj/Sdk/Sdk.targets#L67 |
Or maybe it never worked? .nuspec format: <packageTypes>
<packageType name="Dacpac" />
</packageTypes>
|
@ErikEJ I'm guessing that setting that |
@jmezach I removed it! 😄 - certainly confused me! |
@jmezach I just noticed this: https://github.com/rr-wfm/MSBuild.Sdk.SqlProj?tab=readme-ov-file#packaging-standalone-dacpacs - should the readme also have it removed in this section? |
Yeah, I'd say so |
fixes #283
@jmezach It looks like the Nuspec properties /metadata (like PackageProject) are not passed? Any suggestions for how to fix it?