Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a Nupkg without a .nuspec #579

Merged
merged 12 commits into from
Jul 15, 2024
Merged

Build a Nupkg without a .nuspec #579

merged 12 commits into from
Jul 15, 2024

Conversation

ErikEJ
Copy link
Collaborator

@ErikEJ ErikEJ commented Jul 13, 2024

fixes #283

@jmezach It looks like the Nuspec properties /metadata (like PackageProject) are not passed? Any suggestions for how to fix it?

@ErikEJ ErikEJ requested review from jeffrosenberg and jmezach July 13, 2024 11:10
@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Jul 14, 2024

@jmezach All is good, I was looking in the wrong place 😄

This is an example of the auto generated .nuspec from the test project:

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
  <metadata>
    <id>TestProject</id>
    <version>2.8.0-beta.29.g04d634525c</version>
    <authors>MSBuild.SDK.SqlProj team</authors>
    <projectUrl>https://github.com/rr-wfm/MSBuild.Sdk.SqlProj/</projectUrl>
    <description>Package Description</description>
    <dependencies>
      <group targetFramework=".NETStandard2.0" />
    </dependencies>
  </metadata>
  <files>
    <file src="C:\Code\Github\MSBuild.Sdk.SqlProj\test\TestProject\bin\Debug\netstandard2.0\TestProject.dacpac" target="tools\TestProject.dacpac" />
  </files>
</package>

README.md Outdated Show resolved Hide resolved
Copy link
Member

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Jul 15, 2024

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Jul 15, 2024

Or maybe it never worked?

.nuspec format:

<packageTypes>
      <packageType name="Dacpac" />
 </packageTypes>

@jmezach
Copy link
Member

jmezach commented Jul 15, 2024

@ErikEJ I'm guessing that setting that packageType property didn't actually do anything, so it wouldn't show up in the resulting .nuspec anyway so that's probably why it just worked. We should probably remove it though to avoid confusion in the future.

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Jul 15, 2024

@jmezach I removed it! 😄 - certainly confused me!

@ErikEJ ErikEJ merged commit 2baa8f8 into rr-wfm:master Jul 15, 2024
14 checks passed
@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Jul 15, 2024

@jmezach I just noticed this: https://github.com/rr-wfm/MSBuild.Sdk.SqlProj?tab=readme-ov-file#packaging-standalone-dacpacs - should the readme also have it removed in this section?

@jmezach
Copy link
Member

jmezach commented Jul 15, 2024

Yeah, I'd say so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic Nuspec generation
3 participants