Update uuid version definition #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since uuid >= 1.0 exists now it would be nice to make the uuid version a little more versatile. The proposed change fixes uuid version mismatches when using this crate with together with uuid >= 1.0.
|
Hmm.. i guess i am missing something but iirc if you are also using uuid >= 1.0 cargo should happily build two separate versions of it and since uuid types are not exposed in public api it wouldn't cause any mismatches. Also i don't thinks features you have added are required. So overall i don't see a reason why it is not just a simple version bump, i.e. |
|
Yes, you are right. It was a copy and paste mistake - sorry for that. The features are not necessary and a simple version bump is enough. I changed it to |
rrevenantt
requested review from
rrevenantt
and removed request for
rrevenantt
rrevenantt
approved these changes
Nov 22, 2022
rrevenantt
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since uuid >= 1.0 exists now it would be nice to make the uuid version a little more versatile. The proposed change fixes uuid version mismatches when using this crate with together with uuid >= 1.0.