Skip to content

Commit

Permalink
Merge pull request #22 from rrigato/dev
Browse files Browse the repository at this point in the history
style setup for book section
  • Loading branch information
rrigato authored Nov 26, 2023
2 parents ad993a0 + 6a3d734 commit b7f4b50
Show file tree
Hide file tree
Showing 4 changed files with 44 additions and 3 deletions.
1 change: 0 additions & 1 deletion .github/workflows/homepage_update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: Updates web application
on:
push:
branches:
- dev
- master

jobs:
Expand Down
4 changes: 4 additions & 0 deletions static/css/homepageSection.css
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ ul{
margin-right: 10px;
}

.book-details{
list-style-position: inside;
}

.homepage-content{
background-color: #aaaaaa;
border-radius: 5%;
Expand Down
37 changes: 35 additions & 2 deletions static/js/BookRecommendations.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,49 @@ import React from 'react';
import '../css/homepageSection.css';

/**Book Recommendations
*
* @returns react jsx
*
* @returns react jsx
*/
export function BookRecommendations(){
return(
<div className='homepage-content'>
<div>
<ul>
<h3>Everyday Reads</h3>
<li>Incerto by
<a href='https://en.wikipedia.org/wiki/Nassim_Nicholas_Taleb#Writing_career'>Nassim Taleb</a>

</li>
<li className='book-details'>
Five book collection centered around the understanding the impacts of randomness.
</li>


<h3>Software Engineering</h3>

<li>Clean Architecture by
<a href='https://www.amazon.com/Clean-Architecture-Craftsmans-Software-Structure/dp/0134494164'>Bob Martin</a>
</li>
<li className='book-details'>
The goal of software architecture is to minimize the human resources required to build and maintain the desired application.
</li>

<li>Rework by
<a href='https://basecamp.com/books/rework'
>DHH and Jason Fried</a>
</li>
<li className='book-details'>
Outlines office culture for working remote
</li>

<li>Shape Up by
<a href='https://basecamp.com/shapeup'>Ryan Singer</a>
</li>
<li className='book-details'>
Outside of the fact that he objectively has the coolest first name a human can have,
this is the definitive guide on how iterations should be structured in any devops oriented team.
</li>

</ul>
</div>
</div>
Expand Down
5 changes: 5 additions & 0 deletions static/tests/BookRecommendations.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,14 @@ describe('BookRecommendations displayed on screen', () => {
const {getAllByRole, getByRole} = render(<BookRecommendations/>);


const bookLinks = getAllByRole(
'link'
);
const numHeaders = getAllByRole(
'heading'
);
expect(bookLinks.length).toBe(4);
expect(numHeaders.length).toBe(2);

});
});

0 comments on commit b7f4b50

Please sign in to comment.