Add configuration selection logging

[glenharris]

Add logging of configuration used, along with warning if no specific configuration found

[rrooggiieerr]

I think setting an empty config is a bit tricky. Some projectors only report their model name when they are on, end give an error when they are off. Setting it to empty lets self.projector_config is None fail and the projector config will never be loaded once the projector is on.

[glenharris]

OK, I am not a python expert, so not sure of the best way to proceed. Originally I just left the projector_config as None, but because get_config is called multiple times, you end up with multiple warnings. I could have put a guard around the warning so it only gets printed once, but that seems like overkill (unless there is a builtin logging 'once' primitive or something). My thought was just to use a sentinel to show that 'configuration has attempted to load but nothing was found', and {} seemed to work (remember, not python expert!). To be honest, from a coding point of view, it seems like it would be valuable for runtime code to understand whether or not a specific configuration was loaded. By using a sentinel they can always reset it to None and force a reload (e.g. once model has been detected). Summary: I think it would be nice to be explicit about if a configuration is loaded or not, but I don't know enough about Python or your runtime assumptions to know the right way to do it. Hope this helps.

…

On Tue, 11 Jun 2024 at 08:04, rrooggiieerr ***@***.***> wrote: I think setting an empty config is a bit tricky. Some projectors only report their model name when they are on, end give an error when they are off. Setting it to empty lets self.projector_config is None fail and the projector config will never be loaded once the projector is on. — Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEXJK6D7CMP2PMS4VXQSZ2TZGYBC7AVCNFSM6AAAAABJC53UUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJZGE4DONRWHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[rrooggiieerr]

Ok, I'll just keep your pull reques as a reference for now, will get back to it later.

FYI, this is the issue where a model only shows it's model name when on, if you're interested.

rrooggiieerr/homeassistant-benqprojector#12

[glenharris]

I dont know if this is OK for you, but it should be pretty benign (if you decide to use this, maybe just squash the two commits when applying)