Component projection #124
Open
Component projection #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures PCA reconstructs data Ensures ICA uses same subspace as PCA via recontruction
|
This already looks great! I just removed a bit of whitespace and merged the master in such that the automatic checks are passed here. I think it would be great if you could extend your components object a bit such that it can take a Dataset object as a starting point as well and then can also return a dataset object with the corresponding descriptors. |
|
Issues
======
- Added 2
Complexity increasing per file
==============================
- tests/test_components.py 2
- pyrsa/data/components.py 3
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to calculate RDMs on data subspaces