You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #36 GO's "protein trimerization" was imported into MOP as a subclass of trimerization (MOP:0000715). This will most likely lead to issues downstream if MOP and GO are to be combined and protein trimerization being defined thus as a subclass of trimerization in MOP and also a subclass of protein complex oligomerization in GO.
The text was updated successfully, but these errors were encountered:
@colinbatchelor it might be better to resume the discussion about this axiom injection here, instead of my closed PR.
As said there, injecting this subclass of axiom on protein trimerization would probably be considered problematic. Especially, since we didn't tag it as an injected axiom or have a "base" MOP release, which doesn't contain it. Having said that, the question is, how we proceed.
I see two possible solutions:
drop protein trimerization from MOP but add an editor note which links to this issue, in order to avert the bad code smell of having cyclotrimerization as the only child of trimerization
consult with the GO and/or OBO/COB team where to assert this bridge axiom in order to be OBO principles compliant
In #36 GO's "protein trimerization" was imported into MOP as a subclass of trimerization (MOP:0000715). This will most likely lead to issues downstream if MOP and GO are to be combined and protein trimerization being defined thus as a subclass of trimerization in MOP and also a subclass of protein complex oligomerization in GO.
The text was updated successfully, but these errors were encountered: