Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete protein trimerization (GO:0070206) from mop.owl and mop.obo #46

Conversation

StroemPhi
Copy link
Contributor

closes #45

@batchelorc
Copy link
Collaborator

only reason for putting it in would be to avoid the code smell of having a single child of trimerisation

@batchelorc batchelorc closed this May 11, 2022
@StroemPhi StroemPhi deleted the 45_revert_import_of_GO-0070206 branch May 11, 2022 13:56
@StroemPhi
Copy link
Contributor Author

StroemPhi commented May 11, 2022

@batchelorc I understand the single child problem. But mixing macromolecular and molecular processes is worse, I think.

@StroemPhi
Copy link
Contributor Author

Any macro-molecular process must be a molecular process off course, so please excuse my lap of thinking. What I actually meant was that inserting this subclass of axiom into GO by asserting it in MOP should be seen as problematic according to OBOFoundry/OBOFoundry.github.io#1443. If I understand that issue thread correctly, we would have to consult with the GO developers first before making such an assertion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revert MIREOT style import of GO's "protein trimerization" in #36
2 participants