Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rskip 419 #463

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Update rskip 419 #463

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a394d29
Add new bridge methods specification to rskip
julia-zack Dec 17, 2024
8f093cb
Merge pull request #461 from rsksmart/add_new_bridge_methods
julia-zack Dec 18, 2024
866630e
Update svp fund tx hash signed to svp fund tx signed
julia-zack Dec 17, 2024
bd9ee15
Merge pull request #462 from rsksmart/modify_svp_fundtx_value_being_s…
julia-zack Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions IPs/RSKIP419.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ description: New Mechanism for current Powpeg to ensure the newly elected Powpeg

|RSKIP |419 |
| :------------ |:-------------|
|**Title** |Powpeg Spendability Validation Protocol |
|**Created** |31-AUG-23 |
|**Author** |JD, JZ |
|**Title** |Powpeg Spendability Validation Protocol|
|**Created** |31-AUG-23|
|**Author** |JD, JZ|
|**Purpose** |Sec|
|**Layer** |Core|
|**Complexity** |2|
Expand Down Expand Up @@ -119,7 +119,7 @@ It should verify:
- Transaction hash without signatures matches the record in the `svpFundTxHashUnsigned` storage entry


Once everything is verified, the transaction will be registered and the transaction hash will be saved in a new storage entry, `svpFundTxHashSigned`. Also, the `svpFundTxHashUnsigned` will be removed from the storage.
Once everything is verified, the transaction will be registered and the transaction hash will be saved in a new storage entry, `svpFundTxSigned`. Also, the `svpFundTxHashUnsigned` will be removed from the storage.
The funding transaction hash signed being saved means that the proof transaction can be created.


Expand All @@ -138,15 +138,15 @@ Since the `proposedFederation` still exists, this implies the proof transaction
- The election will be allowed once again.

- SVP period still ongoing
- If the funding transaction signed hash is registered in the `svpFundTxHashSigned` storage entry, the Bridge will:
- If the funding transaction signed hash is registered in the `svpFundTxSigned` storage entry, the Bridge will:
- Create it as described [here](#proof-transaction)
- Add it to a new storage set, key `svpSpendTxWaitingForSignatures`
- Set it in a new Storage entry:
```
KEY: "svpSpendTxHashUnsigned"
VALUE: hash of SVP proof tx without signatures
```
- Remove the `svpFundTxHashSigned` from the storage
- Remove the `svpFundTxSigned` from the storage

##### Proof transaction

Expand All @@ -158,11 +158,11 @@ Proof transaction structure:
{
inputs: [
{
txid: SVP_FUND_TX_HASH_SIGNED,
txid: SVP_FUND_TX_SIGNED_HASH,
output_index: SVP_FUNDING_TX_OUTPUT_INDEX
},
{
txid: SVP_FUND_TX_HASH_SIGNED,
txid: SVP_FUND_TX_SIGNED_HASH,
output_index: SVP_FLYOVER_FUNDING_TX_OUTPUT_INDEX
}
],
Expand Down Expand Up @@ -218,21 +218,28 @@ The recommendation is that this phase takes approximately the blocks a peg-out c
|:------------ |:-------------|
|proposedFederation | voted federation pending to be validated|
|svpFundTxHashUnsigned | hash of SVP funding tx unsigned|
|svpFundTxHashSigned | hash of SVP funding tx signed|
|svpFundTxSigned | SVP funding tx signed|
|svpSpendTxHashUnsigned | hash of SVP proof tx|
|svpSpendTxWaitingForSignatures | SVP proof tx that is to be signed|

### New Bridge methods
```
addSvpSpendTxSignature(bytes federatorPublicKeySerialized, bytes[] signatures)
getProposedFederationAddress() returns string
```

```
getStateForSvpClient() returns bytes
getProposedFederationSize() returns int256
```
```
getProposedFederatorPublicKeyOfType(int256 index, string type) returns bytes
```

```
registerSvpSpendTransaction(bytes svpSpendTxSerialized, uint256 height, bytes pmtSerialized) returns int
getProposedFederationCreationTime() returns int256
```
```
getProposedFederationCreationBlockNumber() returns int256
```
```
getStateForSvpClient() returns bytes
```

### New Bridge events
Expand Down