Feat/upgrade dependencies Next/React #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency ReviewThe following issues were found:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/app/lib/action.ts
Fixed
| logger.dispensed(dispenseAddress, txHash); | ||
|
|
||
| try { | ||
| const currentAddress = faucetHistory[dispenseAddress]; | ||
| currentAddress.loading = true; | ||
| const receipt = await web3.eth.sendSignedTransaction(encodedTx); | ||
|
|
||
| const receipt = await web3.eth.sendSignedTransaction(signedTx.rawTransaction); |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
There was a problem hiding this comment.
This is solved in further commit (5ba4786)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an upgrade of different critical dependencies, included the next:
React from 18 to 19
Next from 14 to 15
Important change: Previous react-card-carousel was not compatible with this upgrade (hasn't been maintained since 4 years ago) so it was changed to swiper carousel package (which is currently maintained)
Also upgrading some other minor dependencies.