Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

feat(rns): handles confirmations for buying domains #686

Merged
merged 6 commits into from
Feb 2, 2021
Merged

feat(rns): handles confirmations for buying domains #686

merged 6 commits into from
Feb 2, 2021

Conversation

itofarina
Copy link
Contributor

@itofarina itofarina commented Jan 28, 2021 •
edited
Loading

Related to #607

  • track buy domain confirmations
  • show loader on buy screen
  • show loader on your domains screen
  • remove done page, move functionality to checkout page
  • reduce complexity of checkout page component

@itofarina itofarina requested a review from jurajpiar as a code owner January 28, 2021 20:31
@itofarina itofarina self-assigned this Jan 28, 2021
@itofarina itofarina marked this pull request as draft January 28, 2021 20:31
@itofarina itofarina changed the title refactor: re-creartes market context with proper structure feat(rns): handles confirmations for buying domains Jan 28, 2021
@itofarina itofarina force-pushed the feat/buyConfirmationsRns branch from 81c1b25 to dbc572f Compare January 29, 2021 14:54
@itofarina itofarina force-pushed the feat/buyConfirmationsRns branch from dbc572f to 162b7e8 Compare January 29, 2021 18:07
@itofarina itofarina force-pushed the feat/buyConfirmationsRns branch from 2b8e370 to 4ea2d21 Compare February 1, 2021 16:27
@itofarina
refactor(rns-buy): reduces component complexity
d92ac6f 
- also improves performance by importing independent modules separatedly
@itofarina itofarina force-pushed the feat/buyConfirmationsRns branch from 4ea2d21 to d92ac6f Compare February 1, 2021 16:33
@itofarina itofarina marked this pull request as ready for review February 1, 2021 16:42
@itofarina itofarina mentioned this pull request Feb 1, 2021
Merged
jurajpiar
jurajpiar suggested changes Feb 2, 2021
View reviewed changes
Copy link
Member

@jurajpiar jurajpiar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG except for my comments and queries bellow.

src/components/pages/rns/buy/DomainOffersPage.tsx Show resolved Hide resolved
src/components/pages/rns/buy/DomainOffersPage.tsx Show resolved Hide resolved
src/components/pages/rns/RnsRoutes.tsx Show resolved Hide resolved
@jurajpiar
Copy link
Member

Also, created an issue to refactor the confirmations interface as I believe the actions passed can be done neater: #692
Please comment there, if you've got any.

@itofarina itofarina merged commit 0fed746 into master Feb 2, 2021
@itofarina itofarina deleted the feat/buyConfirmationsRns branch February 2, 2021 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jurajpiar jurajpiar jurajpiar approved these changes

@julianmrodri julianmrodri Awaiting requested review from julianmrodri

Assignees

@itofarina itofarina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itofarina @jurajpiar