Fixes sgx main loop not handling signals properly #282
+15
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
italo-sampaio
force-pushed
the
fix/unsafe-signal-handling
branch
2 times, most recently
from
cc0bf99 to
1f1b806
Compare
This reverts commit 5e63f11.
Introduces a global counter to ensure finalise_with is only called once.
italo-sampaio
force-pushed
the
fix/unsafe-signal-handling
branch
from
1f1b806 to
c569c92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main loop blocks while waiting for client data. For this reason, we can't just check for the stop condition synchronously. In any case, we still need to ensure that the finalise logic is only called once.
This PR reverts commit 1ec2d35 and introduces a global counter to ensure
finalise_withis only called once.