squashme: makes safer test

rsksmart · Apr 1, 2024 · 0c67641 · 0c67641
1 parent bec94de
commit 0c67641
Showing 1 changed file with 18 additions and 6 deletions.
diff --git a/rskj-core/src/test/java/co/rsk/net/discovery/PeerExplorerTest.java b/rskj-core/src/test/java/co/rsk/net/discovery/PeerExplorerTest.java
@@ -265,9 +265,15 @@ void handlePongMessage() throws Exception {
         assertEquals(1, peerExplorer.getNodes().size());
 
         // Verify that only IP is being sent, not hostname
-        for (Node discoveredNode : peerExplorer.getNodes()) {
-            assertNotEquals(HOST_1, discoveredNode.getHost());
-        }
+        Optional<Node> discoveredNode = peerExplorer.getNodes().stream().filter((Node aNode) -> {
+            String nodeIP = aNode.getAddress().getAddress().getHostAddress();
+            Node localhostNode = new Node(key1.getNodeId(), HOST_1, PORT_1);
+            String localhostIP = localhostNode.getAddress().getAddress().getHostAddress();
+
+            return Objects.equals(nodeIP, localhostIP);
+        }).findFirst();
+        assertTrue(discoveredNode.isPresent());
+        assertNotEquals(HOST_1, discoveredNode.get().getHost());
 
         peerExplorer.dispose();
     }
@@ -432,9 +438,15 @@ void handleFindNodeMessage() throws Exception {
         assertEquals(1, neighborsPeerMessage.getNodes().size());
 
         // Verify that only IP is being sent, not hostname
-        for (Node discoveredNode : neighborsPeerMessage.getNodes()) {
-            assertNotEquals(HOST_1, discoveredNode.getHost());
-        }
+        Optional<Node> discoveredNode = peerExplorer.getNodes().stream().filter((Node aNode) -> {
+            String nodeIP = aNode.getAddress().getAddress().getHostAddress();
+            Node localhostNode = new Node(key1.getNodeId(), HOST_1, PORT_1);
+            String localhostIP = localhostNode.getAddress().getAddress().getHostAddress();
+
+            return Objects.equals(nodeIP, localhostIP);
+        }).findFirst();
+        assertTrue(discoveredNode.isPresent());
+        assertNotEquals(HOST_1, discoveredNode.get().getHost());
 
         peerExplorer.dispose();
     }