Skip to content

Commit

Permalink
Remove tests that were code oriented instead of business logic oriented
Browse files Browse the repository at this point in the history
  • Loading branch information
nathanieliov authored and marcos-iov committed Oct 18, 2024
1 parent fa5793d commit c70a72e
Showing 1 changed file with 0 additions and 47 deletions.
47 changes: 0 additions & 47 deletions rskj-core/src/test/java/co/rsk/peg/PegUtilsLegacyTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -1147,29 +1147,6 @@ void testIsValidPegInTx_utxo_equal_to_minimum_after_RSKIP293() {
));
}

@Test
void testIsValidPegInTx_p2shErpScript_sends_funds_to_federation_address_before_RSKIP353() {
Federation genesisFederation = FederationTestUtils.getGenesisFederation(federationConstantsMainnet);
Address activeFederationAddress = genesisFederation.getAddress();
testIsValidPegInTx_fromP2shErpScriptSender(
false,
false,
activeFederationAddress,
false
);
}

@Test
void testIsValidPegInTx_p2shErpScript_sends_funds_to_random_address_before_RSKIP353() {
Address randomAddress = PegTestUtils.createRandomP2PKHBtcAddress(networkParameters);
testIsValidPegInTx_fromP2shErpScriptSender(
false,
false,
randomAddress,
false
);
}

@Test
void testIsValidPegInTx_p2shErpScript_sends_funds_to_federation_address_after_RSKIP353() {
Federation genesisFederation = FederationTestUtils.getGenesisFederation(federationConstantsMainnet);
Expand All @@ -1193,30 +1170,6 @@ void testIsValidPegInTx_p2shErpScript_sends_funds_to_random_address_after_RSKIP3
);
}

@Test
void testIsValidPegInTx_flyoverP2shErpScript_sends_funds_to_federation_address_before_RSKIP353() {
Federation genesisFederation = FederationTestUtils.getGenesisFederation(federationConstantsMainnet);
Address activeFederationAddress = genesisFederation.getAddress();
testIsValidPegInTx_fromP2shErpScriptSender(
false,
true,
activeFederationAddress,
false
);
}

// It shouldn't identify transactions sent to random addresses as peg-in, but it is the current behaviour
@Test
void testIsValidPegInTx_flyoverP2shErpScript_sends_funds_to_random_address_before_RSKIP353() {
Address randomAddress = PegTestUtils.createRandomP2PKHBtcAddress(networkParameters);
testIsValidPegInTx_fromP2shErpScriptSender(
false,
true,
randomAddress,
false
);
}

@Test
void testIsValidPegInTx_flyoverpP2shErpScript_sends_funds_to_federation_address_after_RSKIP353() {
Federation activeFederation = FederationTestUtils.getGenesisFederation(federationConstantsMainnet);
Expand Down

0 comments on commit c70a72e

Please sign in to comment.