Update config value range check

rsksmart · Jan 29, 2024 · dafb20a · dafb20a
1 parent 65dd358
commit dafb20a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/rskj-core/src/main/java/co/rsk/config/RskSystemProperties.java b/rskj-core/src/main/java/co/rsk/config/RskSystemProperties.java
@@ -189,10 +189,10 @@ public boolean isWalletEnabled() {
     public double gasPriceMultiplier() {
         double gasPriceMultiplier = getDouble(RPC_GAS_PRICE_MULTIPLIER_CONFIG, 1.1);
 
-        if(gasPriceMultiplier > 1.0) {
+        if(gasPriceMultiplier >= 0) {
             return gasPriceMultiplier;
         } else {
-            throw new RskConfigurationException(RPC_GAS_PRICE_MULTIPLIER_CONFIG + " must be greater than 1.0");
+            throw new RskConfigurationException(RPC_GAS_PRICE_MULTIPLIER_CONFIG + " cannot be a negative number");
         }
     }
 

diff --git a/rskj-core/src/test/java/co/rsk/config/RskSystemPropertiesTest.java b/rskj-core/src/test/java/co/rsk/config/RskSystemPropertiesTest.java
@@ -243,12 +243,22 @@ void testGasPriceMultiplierWithNull() {
     }
 
     @Test
-    void testGasPriceMultiplierThrowsError() {
+    void testGasPriceMultiplierThrowsErrorForInvalidType() {
         TestSystemProperties testSystemProperties = new TestSystemProperties(rawConfig ->
                 ConfigFactory.parseString("{" +
                         "rpc.gasPriceMultiplier = invalid" +
                         " }").withFallback(rawConfig));
 
         Assertions.assertThrows(ConfigException.WrongType.class, testSystemProperties::gasPriceMultiplier);
     }
+
+    @Test
+    void testGasPriceMultiplierThrowsErrorForNegativeValue() {
+        TestSystemProperties testSystemProperties = new TestSystemProperties(rawConfig ->
+                ConfigFactory.parseString("{" +
+                        "rpc.gasPriceMultiplier = -1" +
+                        " }").withFallback(rawConfig));
+
+        Assertions.assertThrows(RskConfigurationException.class, testSystemProperties::gasPriceMultiplier);
+    }
 }