Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSKIP 351 + RSKIP 144 #1930

Merged
merged 112 commits into from
Oct 9, 2024

Merge branch 'master' into rskip351+rskip144

63c08da
Select commit
Loading
Failed to load commit list.
Merged

RSKIP 351 + RSKIP 144 #1930

Merge branch 'master' into rskip351+rskip144
63c08da
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Oct 8, 2024 in 3s

19 new alerts

New alerts in code changed by this pull request

  • 1 warning
  • 18 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 108 in rskj-core/src/main/java/co/rsk/core/bc/ReadWrittenKeysTracker.java

See this annotation in the file changed.

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
IReadWrittenKeysTracker.detectCollision
Loading
; it is advisable to add an Override annotation.

Check notice on line 343 in rskj-core/src/main/java/org/ethereum/core/BlockHeader.java

See this annotation in the file changed.

Code scanning / CodeQL

Possible confusion of local and field Note

Potentially confusing name: method
getEncoded
Loading
also refers to field
parentHash
Loading
(as this.parentHash).

Check notice on line 345 in rskj-core/src/main/java/org/ethereum/core/BlockHeader.java

See this annotation in the file changed.

Code scanning / CodeQL

Possible confusion of local and field Note

Potentially confusing name: method
getEncoded
Loading
also refers to field
unclesHash
Loading
(as this.unclesHash).

Check notice on line 348 in rskj-core/src/main/java/org/ethereum/core/BlockHeader.java

See this annotation in the file changed.

Code scanning / CodeQL

Possible confusion of local and field Note

Potentially confusing name: method
getEncoded
Loading
also refers to field
stateRoot
Loading
(as this.stateRoot).

Check notice on line 354 in rskj-core/src/main/java/org/ethereum/core/BlockHeader.java

See this annotation in the file changed.

Code scanning / CodeQL

Possible confusion of local and field Note

Confusing name: method
getEncoded
Loading
also refers to field
txTrieRoot
Loading
(without qualifying it with 'this').

Check notice on line 360 in rskj-core/src/main/java/org/ethereum/core/BlockHeader.java

See this annotation in the file changed.

Code scanning / CodeQL

Possible confusion of local and field Note

Confusing name: method
getEncoded
Loading
also refers to field
receiptTrieRoot
Loading
(without qualifying it with 'this').

Check notice on line 365 in rskj-core/src/main/java/org/ethereum/core/BlockHeader.java

See this annotation in the file changed.

Code scanning / CodeQL

Possible confusion of local and field Note

Potentially confusing name: method
getEncoded
Loading
also refers to field
gasLimit
Loading
(as this.gasLimit).

Check notice on line 368 in rskj-core/src/main/java/org/ethereum/core/BlockHeader.java

See this annotation in the file changed.

Code scanning / CodeQL

Possible confusion of local and field Note

Potentially confusing name: method
getEncoded
Loading
also refers to field
extraData
Loading
(as this.extraData).

Check notice on line 385 in rskj-core/src/main/java/org/ethereum/core/BlockHeader.java

See this annotation in the file changed.

Code scanning / CodeQL

Possible confusion of local and field Note

Potentially confusing name: method
getEncoded
Loading
also refers to field
bitcoinMergedMiningHeader
Loading
(as this.bitcoinMergedMiningHeader).

Check notice on line 388 in rskj-core/src/main/java/org/ethereum/core/BlockHeader.java

See this annotation in the file changed.

Code scanning / CodeQL

Possible confusion of local and field Note

Potentially confusing name: method
getEncoded
Loading
also refers to field
bitcoinMergedMiningMerkleProof
Loading
(as this.bitcoinMergedMiningMerkleProof).

Check notice on line 390 in rskj-core/src/main/java/org/ethereum/core/BlockHeader.java

See this annotation in the file changed.

Code scanning / CodeQL

Possible confusion of local and field Note

Potentially confusing name: method
getEncoded
Loading
also refers to field
bitcoinMergedMiningCoinbaseTransaction
Loading
(as this.bitcoinMergedMiningCoinbaseTransaction).

Check notice on line 655 in rskj-core/src/test/java/co/rsk/core/BlockHeaderTest.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note test

Invoking
PegTestUtils.createHash3
Loading
should be avoided because it has been deprecated.

Check notice on line 18 in rskj-core/src/test/java/co/rsk/core/BlockHeaderV0Test.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note test

Invoking
PegTestUtils.createHash3
Loading
should be avoided because it has been deprecated.

Check notice on line 20 in rskj-core/src/test/java/co/rsk/core/BlockHeaderV1Test.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note test

Invoking
PegTestUtils.createHash3
Loading
should be avoided because it has been deprecated.

Check notice on line 568 in rskj-core/src/test/java/co/rsk/core/bc/BlockExecutorTest.java

See this annotation in the file changed.

Code scanning / CodeQL

Unread local variable Note test

Variable 'BlockResult blockResult' is never read.

Check warning on line 627 in rskj-core/src/test/java/co/rsk/core/bc/BlockExecutorTest.java

See this annotation in the file changed.

Code scanning / CodeQL

Result of multiplication cast to wider type Warning test

Potential overflow in
int multiplication
Loading
before it is converted to long by use in an invocation context.

Check notice on line 524 in rskj-core/src/test/java/co/rsk/core/bc/ReadWrittenKeysTrackerTest.java

See this annotation in the file changed.

Code scanning / CodeQL

Missing Override annotation Note test

This method overrides
Callable.call
Loading
; it is advisable to add an Override annotation.

Check notice on line 267 in rskj-core/src/test/java/org/ethereum/core/BlockHeaderBuilderTest.java

See this annotation in the file changed.

Code scanning / CodeQL

Possible confusion of local and field Note test

Potentially confusing name: method
createsHeaderWith
Loading
also refers to field
blockHeaderBuilder
Loading
(as this.blockHeaderBuilder).

Check notice on line 1428 in rskj-core/src/test/java/org/ethereum/rpc/Web3ImplTest.java

See this annotation in the file changed.

Code scanning / CodeQL

Useless parameter Note test

The parameter 'config' is never used.