Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding BASEFEE Method #2174

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Adding BASEFEE Method #2174

merged 6 commits into from
Dec 11, 2023

Conversation

nagarev
Copy link
Contributor

@nagarev nagarev commented Nov 9, 2023 •
edited
Loading

Adding BASEFEE method

Description

The BASEFEE Opcode (EIP-3198) gives the EVM access to the block’s base fee. This PR aims to add support for that method on RSKj.

Motivation and Context

Maintain compatibility with ETH.

How Has This Been Tested?

  • Local testing
  • Automated tests
  • QA

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

REQUIRES HF ACTIVATION

Vovchyk
Vovchyk previously approved these changes Nov 10, 2023
View reviewed changes
@nagarev nagarev changed the title Refactoring method name Adding BASEFEE Method Nov 10, 2023
@nagarev nagarev requested a review from Vovchyk November 20, 2023 20:34
@nagarev nagarev marked this pull request as ready for review November 21, 2023 13:23
@nagarev nagarev requested a review from casiojapi November 21, 2023 13:24
@nagarev
Copy link
Contributor Author

nagarev commented Nov 24, 2023

pipeline:run

6 similar comments
@Vovchyk
Copy link
Contributor

Vovchyk commented Nov 27, 2023

pipeline:run

@Vovchyk
Copy link
Contributor

Vovchyk commented Nov 27, 2023

pipeline:run

@nagarev
Copy link
Contributor Author

nagarev commented Nov 27, 2023

pipeline:run

@Vovchyk
Copy link
Contributor

Vovchyk commented Nov 28, 2023

pipeline:run

@Vovchyk
Copy link
Contributor

Vovchyk commented Nov 28, 2023

pipeline:run

@Vovchyk
Copy link
Contributor

Vovchyk commented Nov 28, 2023

pipeline:run

asoto-iov
asoto-iov reviewed Nov 28, 2023
View reviewed changes
rskj-core/src/test/java/co/rsk/vm/opcode/BasefeeDslTest.java
@@ -0,0 +1,149 @@
package co.rsk.vm.opcode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it is needed in test classes too, but copyright header missing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally! Will add it!

asoto-iov
asoto-iov previously approved these changes Nov 28, 2023
View reviewed changes
@nagarev nagarev requested a review from asoto-iov November 29, 2023 11:59
Vovchyk
Vovchyk previously approved these changes Nov 29, 2023
View reviewed changes
@nagarev
Copy link
Contributor Author

nagarev commented Nov 29, 2023

pipeline:run

2 similar comments
@nagarev
Copy link
Contributor Author

nagarev commented Nov 30, 2023

pipeline:run

@nagarev
Copy link
Contributor Author

nagarev commented Nov 30, 2023

pipeline:run

@nagarev
Copy link
Contributor Author

nagarev commented Dec 1, 2023

pipeline:run

4 similar comments
@Vovchyk
Copy link
Contributor

Vovchyk commented Dec 4, 2023

pipeline:run

@nagarev
Copy link
Contributor Author

nagarev commented Dec 7, 2023

pipeline:run

@nagarev
Copy link
Contributor Author

nagarev commented Dec 7, 2023

pipeline:run

@nagarev
Copy link
Contributor Author

nagarev commented Dec 7, 2023

pipeline:run

@nagarev nagarev requested a review from Vovchyk December 7, 2023 14:46
@nagarev
Copy link
Contributor Author

nagarev commented Dec 7, 2023

pipeline:run

11 similar comments
@nagarev
Copy link
Contributor Author

nagarev commented Dec 7, 2023

pipeline:run

@nagarev
Copy link
Contributor Author

nagarev commented Dec 8, 2023

pipeline:run

@nagarev
Copy link
Contributor Author

nagarev commented Dec 8, 2023

pipeline:run

@nagarev
Copy link
Contributor Author

nagarev commented Dec 8, 2023

pipeline:run

@nagarev
Copy link
Contributor Author

nagarev commented Dec 8, 2023

pipeline:run

@nagarev
Copy link
Contributor Author

nagarev commented Dec 8, 2023

pipeline:run

@Vovchyk
Copy link
Contributor

Vovchyk commented Dec 11, 2023

pipeline:run

@Vovchyk
Copy link
Contributor

Vovchyk commented Dec 11, 2023

pipeline:run

@Vovchyk
Copy link
Contributor

Vovchyk commented Dec 11, 2023

pipeline:run

@Vovchyk
Copy link
Contributor

Vovchyk commented Dec 11, 2023

pipeline:run

@Vovchyk
Copy link
Contributor

Vovchyk commented Dec 11, 2023

pipeline:run

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

75.4% 75.4% Coverage
0.0% 0.0% Duplication

@Vovchyk Vovchyk merged commit df71611 into master Dec 11, 2023
5 checks passed
@Vovchyk Vovchyk deleted the implement-basefee branch December 11, 2023 13:47
@aeidelman aeidelman added this to the Arrowhead 6.0.0 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vovchyk Vovchyk Vovchyk approved these changes

@casiojapi casiojapi Awaiting requested review from casiojapi

@rmoreliovlabs rmoreliovlabs Awaiting requested review from rmoreliovlabs

@asoto-iov asoto-iov Awaiting requested review from asoto-iov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Arrowhead 6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nagarev @Vovchyk @asoto-iov @aeidelman