-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating how eth_gasPrice is calculated #2176
Conversation
import static org.mockito.Mockito.mock; | ||
import static org.mockito.Mockito.when; | ||
|
||
class EthereumImplTest { |
Check notice
Code scanning / CodeQL
Unused classes and interfaces Note test
pipeline:run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5a28036
to
705e16d
Compare
pipeline:run |
2 similar comments
pipeline:run |
pipeline:run |
e507c82
to
9f7f838
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
We are updating the logic about how the gas price data returned by the eth_gasPrice rpc method is calculated.
Description
The new behaviour is:
2.If a market is working (isFeeMarketWorking() returns true) , then eth_gasPrice should return same results as it returns right now (no changes in this case).
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: