Adding new rsk_getStorageBytesAt JSON-RPC method #2191

asoto-iov · 2023-11-23T17:35:45Z

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
Tests for the changes have been added (for bug fixes / features)
Requires Activation Code (Hard Fork)

Other information:

rskj-core/src/main/java/org/ethereum/rpc/Web3Impl.java

Vovchyk

we'd probably need to disable this method in here, as it might be resource intensive in some cases

asoto-iov · 2023-11-29T13:39:36Z

we'd probably need to disable this method in here, as it might be resource intensive in some cases

sure, I didn't added as I was testing it locally and then I forgot to do it. Thanks for spotting it!

casiojapi · 2023-11-30T22:40:34Z

rskj-core/src/main/java/co/rsk/rpc/Web3RskModule.java

@@ -47,4 +50,7 @@ default void rsk_flush() {
    }

    RskModule getRskModule();
+
+    String rsk_getStorageBytesAt(HexAddressParam address, HexNumberParam storageIdx, BlockRefParam blockRefParam);


just to understand, is there a reason why the default keyword isn't declared?

I'm only declaring the method and in this case, it is not needed to add default implementation.

default methods are used when you want to implement a default method behavior within an interface to not break compatibility with older implementations. It is mainly used in high-exposure interfaces but here it is not needed.