Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from jmh benchmark #2268

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fix from jmh benchmark #2268

merged 1 commit into from
Mar 8, 2024

Conversation

fmacleal
Copy link
Contributor

@fmacleal fmacleal commented Mar 7, 2024

Fixing EthCallPlan to add gasLimit to the request

Refactoring of branch to merge it to master

In order to fix the jmh benchmarking test, we need to refactor and remove some changes made to run test locally.

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@fmacleal fmacleal force-pushed the fix_jmh_unit_tests branch from dd3c0d7 to 826c1e3 Compare March 7, 2024 16:38
@fmacleal fmacleal requested review from nagarev and Vovchyk March 7, 2024 16:39
Copy link
Contributor

@nagarev nagarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vovchyk
Copy link
Contributor

Vovchyk commented Mar 8, 2024

pipeline:run

Fixing EthCallPlan to add gasLimit to the request

Refactoring of branch to merge it to master

In order to fix the jmh benchmarking test, we need to refactor and remove some changes made to run test locally.
@fmacleal fmacleal force-pushed the fix_jmh_unit_tests branch from 826c1e3 to 4683a65 Compare March 8, 2024 11:37
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Vovchyk
Copy link
Contributor

Vovchyk commented Mar 8, 2024

pipeline:run

1 similar comment
@Vovchyk
Copy link
Contributor

Vovchyk commented Mar 8, 2024

pipeline:run

@Vovchyk Vovchyk merged commit 71b5f5b into master Mar 8, 2024
10 checks passed
@Vovchyk Vovchyk deleted the fix_jmh_unit_tests branch March 8, 2024 13:09
@aeidelman aeidelman added this to the Arrowhead 6.1.0 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants