Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving codeql issues #2274

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Solving codeql issues #2274

merged 1 commit into from
Mar 21, 2024

Conversation

fmacleal
Copy link
Contributor

In order to be able to merge the branch, we have to fix the CodeQL issues with high severity. This branch does it.

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@fmacleal fmacleal changed the base branch from master to snap-v4-final March 21, 2024 11:37
@@ -127,7 +127,7 @@
}

private Message decodeMessage(List<Frame> frames) throws IOException {
long frameType = frames.get(0).getType();
Long frameType = frames.get(0).getType();

Check warning

Code scanning / CodeQL

Boxed variable is never null

The variable 'frameType' is only assigned values of primitive type and is never 'null', but it is declared with the boxed type 'Long'.
@fmacleal fmacleal force-pushed the solving-codeql-issues branch from 6ea6042 to 392b5b7 Compare March 21, 2024 11:53
@fmacleal fmacleal marked this pull request as ready for review March 21, 2024 11:56
@fmacleal fmacleal force-pushed the solving-codeql-issues branch from 392b5b7 to fdda355 Compare March 21, 2024 12:26
Copy link

@fmacleal fmacleal merged commit 0b0fb1e into snap-v4-final Mar 21, 2024
6 checks passed
@marcos-iov marcos-iov deleted the solving-codeql-issues branch May 8, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants