Improve performance of mock getOriginAddress, getCallerAddress

[jurajpiar]

Description

Motivation and Context

The overloaded methods getOriginAddress and getCallerAddress in ProgramInvokeMockImpl perform hashing and secp256k1 base point multiplication each time ORIGIN or CALLER are executed.

rskj/rskj-core/src/test/java/org/ethereum/vm/program/invoke/ProgramInvokeMockImpl.java

Lines 111 to 129 in 12c9b32

	/* ORIGIN op */
	@Override
	public DataWord getOriginAddress() {
	byte[] cowPrivKey = HashUtil.keccak256("horse".getBytes(StandardCharsets.UTF_8));
	byte[] addr = ECKey.fromPrivate(cowPrivKey).getAddress();
	return DataWord.valueOf(addr);
	}
	/* CALLER op */
	@Override
	public DataWord getCallerAddress() {
	byte[] cowPrivKey = HashUtil.keccak256("monkey".getBytes(StandardCharsets.UTF_8));
	byte[] addr = ECKey.fromPrivate(cowPrivKey).getAddress();
	return DataWord.valueOf(addr);
	}

This makes these opcodes unnecessary slow and it impedes my effort to detect genuine performance issues with the EVM itself.

How Has This Been Tested?

With this test harness (rskj-core/src/test/java/co/rsk/vm/Poc.java):

package co.rsk.vm;

import org.ethereum.config.blockchain.upgrades.ActivationConfig;
import co.rsk.config.TestSystemProperties;
import co.rsk.config.VmConfig;
import org.ethereum.vm.*;
import org.ethereum.core.BlockFactory;
import org.ethereum.core.BlockTxSignatureCache;
import org.ethereum.core.ReceivedTxSignatureCache;
import org.ethereum.vm.program.invoke.ProgramInvokeMockImpl;
import java.util.HashSet;
import org.ethereum.vm.program.Program;
import org.ethereum.config.blockchain.upgrades.ActivationConfigsForTest;
import javax.xml.bind.DatatypeConverter;
import org.junit.jupiter.api.Test;

public class Poc {
    @Test
    void testPoc() {
        TestSystemProperties config = new TestSystemProperties();
        PrecompiledContracts precompiledContracts = new PrecompiledContracts(config, null, new BlockTxSignatureCache(new ReceivedTxSignatureCache()));
        BlockFactory blockFactory = new BlockFactory(config.getActivationConfig());
        VmConfig vmConfig = config.getVmConfig();
        ProgramInvokeMockImpl invoke = new ProgramInvokeMockImpl();
        ActivationConfig.ForBlock activations = ActivationConfigsForTest.arrowhead600().forBlock(0);

        byte[] code = DatatypeConverter.parseHexBinary("5b3333331a1a56");

        invoke.setGas(6800000); /* block limit */
        VM vm = new VM(vmConfig, precompiledContracts);
        Program program = new Program(vmConfig, precompiledContracts, blockFactory, activations, code, invoke,null, new HashSet<>(), new BlockTxSignatureCache(new ReceivedTxSignatureCache()));

        try {
            while (!program.isStopped())
                vm.step(program);
        } catch (RuntimeException e) {
            program.setRuntimeFailure(e);
        }
    }
}

Runtime before this fix: 10 minutes, 17 seconds
Runtime after this fix: 6 seconds

Using:

time ./gradlew test  --tests co.rsk.vm.Poc.testPoc

On Linux x64, Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• Tests for the changes have been added (for bug fixes / features)
• Requires Activation Code (Hard Fork)

[jurajpiar]

Thank you very much @guidovranken for your contribution. We have some security-related limitations of our processes that mean we cannot merge outside PRs. We are working on resolving these, but meanwhile we cherry-picked your commit and created a new PR, closing yours.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[jurajpiar]

pipeline:run