Create getSvpSpendTxWaitingForSignatures method #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apancorb
force-pushed
the
feat/get_svp_spend_waiting_signatures
branch
from
879eaff to
5d4c3fa
Compare
julia-zack
reviewed
Sep 17, 2024
rskj-core/src/test/java/co/rsk/peg/BridgeStorageProviderTest.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Sep 17, 2024
rskj-core/src/test/java/co/rsk/peg/BridgeStorageProviderTest.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Sep 17, 2024
rskj-core/src/test/java/co/rsk/peg/BridgeStorageProviderTest.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Sep 17, 2024
rskj-core/src/test/java/co/rsk/peg/BridgeStorageProviderTest.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Sep 17, 2024
rskj-core/src/test/java/co/rsk/peg/BridgeStorageProviderTest.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Sep 17, 2024
rskj-core/src/test/java/co/rsk/peg/BridgeStorageProviderTest.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Sep 17, 2024
rskj-core/src/test/java/co/rsk/peg/BridgeStorageProviderTest.java
Outdated
Show resolved
Hide resolved
marcos-iov
approved these changes
Sep 17, 2024
apancorb
commented
Sep 18, 2024
| @@ -95,7 +95,7 @@ private static byte[][] serializeRskTxWaitingForSignaturesEntry( | |||
| public static Map.Entry<Keccak256, BtcTransaction> deserializeRskTxWaitingForSignatures( | |||
| byte[] data, NetworkParameters networkParameters, boolean noInputsTxs) { | |||
| if (data == null || data.length == 0) { | |||
| return new AbstractMap.SimpleEntry<>(null, null); | |||
| return null; | |||
There was a problem hiding this comment.
We need to return null as it is the new default value.
apancorb
force-pushed
the
feat/get_svp_spend_waiting_signatures
branch
from
d7093c7 to
a3c149a
Compare
julia-zack
reviewed
Sep 18, 2024
rskj-core/src/test/java/co/rsk/peg/BridgeStorageProviderTest.java
Outdated
Show resolved
Hide resolved
julia-zack
approved these changes
Sep 18, 2024
apancorb
force-pushed
the
feat/get_svp_spend_waiting_signatures
branch
from
a3c149a to
aa9ac45
Compare
|
julia-zack
merged commit 644cc3d
into
feature/powpeg_validation_protocol-phase2
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now we are able to save the spend transaction in the
svpSpendTxWaitingForSignaturesentry. So now we need a method to get the transaction saved.Motivation and Context
https://github.com/rsksmart/RSKIPs/blob/master/IPs/RSKIP419.md