Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Skipping SonarQube analysis on prs from forked repos #2805

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Bugfix: Skipping SonarQube analysis on prs from forked repos #2805

merged 1 commit into from
Oct 17, 2024

Conversation

rmoreliovlabs
Copy link
Contributor

@rmoreliovlabs rmoreliovlabs commented Oct 14, 2024 •
edited
Loading

Description

Example pr: #2803
Job: https://github.com/rsksmart/rskj/actions/runs/11334162626

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@rmoreliovlabs rmoreliovlabs requested a review from Vovchyk October 14, 2024 20:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Vovchyk Vovchyk merged commit 918a94e into master Oct 17, 2024
11 checks passed
@Vovchyk Vovchyk deleted the bugfix/skip_sonarqube_forks branch October 17, 2024 12:28
@aeidelman aeidelman added this to the Arrowhead 6.4.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vovchyk Vovchyk Vovchyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Arrowhead 6.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rmoreliovlabs @Vovchyk @aeidelman