Add gas cost #2862
Merged
Add gas cost #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
fmacleal
reviewed
Dec 3, 2024
There was a problem hiding this comment.
praise:
Good job mate, very complete tests.
I have left some comments. Feel free to ask if you have some doubt. Also, I would like to highlight the suggestion in the other PR. Would be nice to refactor the assertions like I suggested in the other PR comment.
rskj-core/src/test/resources/dsl/opcode/mcopy/testRSKIPNotActivatedTest.txt
Outdated
Show resolved
Hide resolved
Vovchyk
requested changes
Dec 5, 2024
|
Vovchyk
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: