-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use clear methods instead of setting null values #2881
Merged
marcos-iov
merged 5 commits into
feature/powpeg_validation_protocol-phase4
from
add_methods_to_clear_svp_values
Dec 9, 2024
Merged
Use clear methods instead of setting null values #2881
marcos-iov
merged 5 commits into
feature/powpeg_validation_protocol-phase4
from
add_methods_to_clear_svp_values
Dec 9, 2024
+215
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
julia-zack
force-pushed
the
return_feds_creation_time_in_seconds
branch
from
December 5, 2024 20:53
1def442
to
90d97c4
Compare
Base automatically changed from
return_feds_creation_time_in_seconds
to
feature/powpeg_validation_protocol-phase4
December 5, 2024 21:02
julia-zack
force-pushed
the
add_methods_to_clear_svp_values
branch
from
December 5, 2024 21:06
4702f00
to
060d1f8
Compare
apancorb
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You might want to look into this. Make sure branches are up to date |
julia-zack
force-pushed
the
add_methods_to_clear_svp_values
branch
from
December 6, 2024 12:31
060d1f8
to
ce50371
Compare
julia-zack
changed the base branch from
feature/powpeg_validation_protocol-phase4
to
return_feds_creation_time_in_seconds
December 6, 2024 12:31
Base automatically changed from
return_feds_creation_time_in_seconds
to
feature/powpeg_validation_protocol-phase4
December 9, 2024 12:17
marcos-iov
force-pushed
the
add_methods_to_clear_svp_values
branch
2 times, most recently
from
December 9, 2024 19:16
41e7704
to
bfe572f
Compare
marcos-iov
force-pushed
the
add_methods_to_clear_svp_values
branch
from
December 9, 2024 19:17
bfe572f
to
dc3bca0
Compare
marcos-iov
approved these changes
Dec 9, 2024
Quality Gate passedIssues Measures |
marcos-iov
merged commit Dec 9, 2024
4bfa2ac
into
feature/powpeg_validation_protocol-phase4
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.