Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clear methods instead of setting null values #2881

Conversation

julia-zack
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Dec 5, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@julia-zack julia-zack force-pushed the return_feds_creation_time_in_seconds branch from 1def442 to 90d97c4 Compare December 5, 2024 20:53
Base automatically changed from return_feds_creation_time_in_seconds to feature/powpeg_validation_protocol-phase4 December 5, 2024 21:02
@julia-zack julia-zack force-pushed the add_methods_to_clear_svp_values branch from 4702f00 to 060d1f8 Compare December 5, 2024 21:06
@julia-zack julia-zack marked this pull request as ready for review December 5, 2024 21:06
@julia-zack julia-zack requested a review from a team as a code owner December 5, 2024 21:06
Copy link
Contributor

@apancorb apancorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apancorb
Copy link
Contributor

apancorb commented Dec 6, 2024

BridgeTest > getActiveFederationCreationTime_returnsCreationTimeInExpectedTimeUnit(ActivationConfig, long) > [1] org.ethereum.config.blockchain.upgrades.ActivationConfig@6ad52052, 5000 FAILED
    java.lang.NullPointerException at BridgeTest.java:2133
Running test: Test getActiveFederationCreationTime_returnsCreationTimeInExpectedTimeUnit(ActivationConfig, long)[2](co.rsk.peg.BridgeTest)

BridgeTest > getActiveFederationCreationTime_returnsCreationTimeInExpectedTimeUnit(ActivationConfig, long) > [2] org.ethereum.config.blockchain.upgrades.ActivationConfig@25006e47, 5 FAILED

You might want to look into this. Make sure branches are up to date

@julia-zack julia-zack force-pushed the add_methods_to_clear_svp_values branch from 060d1f8 to ce50371 Compare December 6, 2024 12:31
@julia-zack julia-zack changed the base branch from feature/powpeg_validation_protocol-phase4 to return_feds_creation_time_in_seconds December 6, 2024 12:31
Base automatically changed from return_feds_creation_time_in_seconds to feature/powpeg_validation_protocol-phase4 December 9, 2024 12:17
@marcos-iov marcos-iov force-pushed the add_methods_to_clear_svp_values branch 2 times, most recently from 41e7704 to bfe572f Compare December 9, 2024 19:16
@marcos-iov marcos-iov force-pushed the add_methods_to_clear_svp_values branch from bfe572f to dc3bca0 Compare December 9, 2024 19:17
@marcos-iov marcos-iov merged commit 4bfa2ac into feature/powpeg_validation_protocol-phase4 Dec 9, 2024
9 checks passed
@marcos-iov marcos-iov deleted the add_methods_to_clear_svp_values branch December 9, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants