Register twice the same transaction, the second time should not modify any state #2893
+149
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
julianlen
changed the base branch from
pegin-tests-integration
to
pegin-it-initialTest
julianlen
force-pushed
the
pegin-it-repeatedTx
branch
from
ea9584e to
171c569
Compare
Base automatically changed from
pegin-it-initialTest
to
pegin-tests-integration
December 16, 2024 18:49
julianlen
force-pushed
the
pegin-tests-integration
branch
from
db3f6bc to
e0c0cc6
Compare
julianlen
force-pushed
the
pegin-it-repeatedTx
branch
from
171c569 to
3d5d7e9
Compare
julia-zack
reviewed
Dec 17, 2024
julia-zack
reviewed
Dec 17, 2024
rskj-core/src/test/java/co/rsk/peg/RegisterBtcTransactionIT.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Dec 17, 2024
rskj-core/src/test/java/co/rsk/peg/RegisterBtcTransactionIT.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Dec 17, 2024
rskj-core/src/test/java/co/rsk/peg/RegisterBtcTransactionIT.java
Outdated
Show resolved
Hide resolved
julianlen
force-pushed
the
pegin-it-repeatedTx
branch
from
97f2977 to
e4f10cd
Compare
…ain event was emitted, besides I moved the method to assert an event to BridgeSupportTestUtil
julianlen
force-pushed
the
pegin-it-repeatedTx
branch
from
e4f10cd to
68a0f15
Compare
julia-zack
approved these changes
Dec 18, 2024
|
julia-zack
reviewed
Dec 18, 2024
| return federationStorageProvider; | ||
| } | ||
| co.rsk.core.Coin expectedReceiverBalance = repository.getBalance(rskReceiver); | ||
| List<UTXO> expectedFederationUTXOs = federationSupport.getActiveFederationBtcUTXOs(); |
There was a problem hiding this comment.
i just noticed that here you are pointing the reference to the utxos, so you end up asserting
federationSupport.getActiveFederationBtcUTXOs().equals(federationSupport.getActiveFederationBtcUTXOs())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added RegisterBtcTransactionIT, a new integration tests suit with the test whenRegisterALegacyBtcTransactionTheBridgeShouldRegisterTheNewUtxoAndTransferTheRbtcBalance.