Use FederationChangeFunctions enum when voting #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
apancorb
reviewed
Dec 19, 2024
julia-zack
commented
Dec 19, 2024
Comment on lines
-547
to
-550
| default: | ||
| // Fail by default | ||
| logger.warn("[executeVoteFederationChangeFunction] Unrecognized called function."); | ||
| result = new ABICallVoteResult(false, FederationChangeResponseCode.GENERIC_ERROR.getCode()); |
There was a problem hiding this comment.
this is no needed since the method is private and we are previously checking here that the function being called is part of the enum
|
nathanieliov
approved these changes
Dec 19, 2024
apancorb
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.