Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create method to remove utxos used for a release transaction #2913

Conversation

julia-zack
Copy link
Contributor

Consumed UTXOs after creating a release transaction were being removed separately in each method.
This should be happening in settleReleaseRequest method, since it is where all the release-releated actions happen.

This pr does that.

Copy link

github-actions bot commented Jan 3, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@julia-zack julia-zack force-pushed the remove_utxos_after_creating_pegout branch 3 times, most recently from 2be0d27 to b337a78 Compare January 6, 2025 18:48
Copy link
Contributor

@apancorb apancorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julia-zack julia-zack force-pushed the remove_utxos_after_creating_pegout branch from b337a78 to 3384792 Compare January 7, 2025 15:03
@julia-zack julia-zack marked this pull request as ready for review January 7, 2025 15:06
@julia-zack julia-zack requested a review from a team as a code owner January 7, 2025 15:06
Copy link
Contributor

@jeremy-then jeremy-then left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marcos-iov marcos-iov merged commit b6cfa3d into feature/powpeg_validation_protocol-phase4 Jan 7, 2025
9 checks passed
@marcos-iov marcos-iov deleted the remove_utxos_after_creating_pegout branch January 7, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants