Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goerli migration #348

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Goerli migration #348

wants to merge 9 commits into from

Conversation

joaoiovlabs
Copy link
Contributor

No description provided.

gsoares85
gsoares85 reviewed Sep 13, 2022
View reviewed changes
bridge/hardhat.config.js
},
tags: ['prod'],
},
// JUST TO AVOID MISTAKES
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove this commented code

bridge/hardhat.config.js
},
tags: ['prod'],
},
// JUST TO AVOID MISTAKES
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

bridge/hardhat.config.js Outdated
@@ -184,7 +173,7 @@ function getMultiSigAddressesByChainId() {
multiSigAddressesByChainId[chains.ETHEREUM_MAIN_NET_CHAIN_ID] = '0x040007b1804ad78a97f541bebed377dcb60e4138';
multiSigAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0x040007b1804ad78a97f541bebed377dcb60e4138';
multiSigAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0x88f6b2bc66f4c31a3669b9b1359524abf79cfc4a';
multiSigAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0x040007b1804ad78a97f541bebed377dcb60e4138';
multiSigAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0x040007b1804ad78a97f541bebed377dcb60e4138'; // TODO: SHOULD BE UPDATED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TODO is done?

bridge/hardhat.config.js Outdated
@@ -195,7 +184,7 @@ function getWrappedCurrencyAddressesByChainId() {
wrappedCurrencyAddressesByChainId[chains.ETHEREUM_MAIN_NET_CHAIN_ID] = '0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2';
wrappedCurrencyAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0x967f8799af07df1534d48a95a5c9febe92c53ae0';
wrappedCurrencyAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0x09b6ca5e4496238a1f176aea6bb607db96c2286e';
wrappedCurrencyAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0xd0A1E359811322d97991E03f863a0C30C2cF029C';
wrappedCurrencyAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0xd0A1E359811322d97991E03f863a0C30C2cF029C'; // TODO: SHOULD BE UPDATED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

bridge/hardhat.config.js Outdated
@@ -207,7 +196,7 @@ function getProxyAdminAddressesByChainId() {
proxyAdminAddressesByChainId[chains.ETHEREUM_MAIN_NET_CHAIN_ID] = '0xe4d351911a6d599f91a3db1843e2ecb0f851e7e6';
proxyAdminAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0x12ed69359919fc775bc2674860e8fe2d2b6a7b5d';
proxyAdminAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0x8c35e166d2dea7a8a28aaea11ad7933cdae4b0ab';
proxyAdminAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0xe4d351911a6d599f91a3db1843e2ecb0f851e7e6';
proxyAdminAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0xe4d351911a6d599f91a3db1843e2ecb0f851e7e6'; // TODO: SHOULD BE UPDATED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

bridge/hardhat.config.js Outdated
@@ -218,7 +207,7 @@ function getAllowTokensProxyAddressesByChainId() {
allowTokensProxyAddressesByChainId[chains.ETHEREUM_MAIN_NET_CHAIN_ID] = '0xa3fc98e0a7a979677bc14d541be770b2cb0a15f3';
allowTokensProxyAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0xcb789036894a83a008a2aa5b3c2dde41d0605a9a';
allowTokensProxyAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0xc65bf0ae75dc1a5fc9e6f4215125692a548c773a';
allowTokensProxyAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0x92bf86334583909b60f9b798a9dd7debd899fec4';
allowTokensProxyAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0x92bf86334583909b60f9b798a9dd7debd899fec4'; // TODO: SHOULD BE UPDATED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

bridge/hardhat.config.js Outdated
@@ -229,7 +218,7 @@ function getBridgeProxyAddressesByChainId() {
bridgeProxyAddressesByChainId[chains.ETHEREUM_MAIN_NET_CHAIN_ID] = '0x12ed69359919fc775bc2674860e8fe2d2b6a7b5d';
bridgeProxyAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0x9d11937e2179dc5270aa86a3f8143232d6da0e69';
bridgeProxyAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0x684a8a976635fb7ad74a0134ace990a6a0fcce84';
bridgeProxyAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0x12ed69359919fc775bc2674860e8fe2d2b6a7b5d';
bridgeProxyAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0x12ed69359919fc775bc2674860e8fe2d2b6a7b5d'; // TODO: SHOULD BE UPDATED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

bridge/hardhat.config.js Outdated
@@ -240,7 +229,7 @@ function getFederationProxyAddressesByChainId() {
federationProxyAddressesByChainId[chains.ETHEREUM_MAIN_NET_CHAIN_ID] = '0x5e29c223d99648c88610519f96e85e627b3abe17';
federationProxyAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0x7ecfda6072942577d36f939ad528b366b020004b';
federationProxyAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0x5d663981d930e8ec108280b9d80885658148ab0f';
federationProxyAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0xa347438bc288f56cb6083a79133e70dd2d1f6c2d';
federationProxyAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0xa347438bc288f56cb6083a79133e70dd2d1f6c2d'; // TODO: SHOULD BE UPDATED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

bridge/hardhat.config.js Outdated
@@ -251,7 +240,7 @@ function getSideTokenFactoryAddressesByChainId() {
sideTokenFactoryAddressesByChainId[chains.ETHEREUM_MAIN_NET_CHAIN_ID] = '0xF73C60863BF2930Bde2c69dF4CB8fE700Ae713fB';
sideTokenFactoryAddressesByChainId[chains.RSK_MAIN_NET_CHAIN_ID] = '0x44fcd0854d745efdef4cfe9868efe4d4eb51ecd6';
sideTokenFactoryAddressesByChainId[chains.RSK_TEST_NET_CHAIN_ID] = '0x08C191A7B5Edaa59853705F7eaE95E3E4238D73e';
sideTokenFactoryAddressesByChainId[chains.KOVAN_TEST_NET_CHAIN_ID] = '0x984192ad76A8FFF2edf39C260324d32d8A80512b';
sideTokenFactoryAddressesByChainId[chains.GOERLY_TEST_NET_CHAIN_ID] = '0x984192ad76A8FFF2edf39C260324d32d8A80512b'; // TODO: SHOULD BE UPDATED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@coveralls
Copy link

coveralls commented Sep 26, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 96.862% when pulling dccafd5 on draft-goerli-migration into 297ed54 on master.

@lgtm-com
Copy link

lgtm-com bot commented Sep 27, 2022

This pull request introduces 1 alert when merging 66cc472 into 297ed54 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@lgtm-com
Copy link

lgtm-com bot commented Sep 28, 2022

This pull request introduces 2 alerts when merging dccafd5 into 297ed54 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

gsoares85
gsoares85 reviewed Sep 29, 2022
View reviewed changes
bridge/deploy/05_deploy_bridgeProxy.js
@@ -30,19 +31,21 @@ module.exports = async function (hre) { // HardhatRuntimeEnvironment
methodCall.encodeABI()
];

const deployProxyResult = await deploy('BridgeProxy', {
const deployResult = await deploy('BridgeProxy', {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let the name deployProxyResult because we are deploying a proxy contract in here

federator/src/contracts/IAllowTokensV0.ts
if (this.chainId === 31 || this.chainId === 42) {
// rsk testnet and kovan
if (this.chainId === 31 || this.chainId === 5) {
// rsk testnet and goerli TO DO: ASK AUGUSTO ABOUT CONFIRMATIONS.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave the number of confirmations as it is and remove this comment

@snyk-bot snyk-bot mentioned this pull request Oct 12, 2022
Open
@Luisfc68 Luisfc68 force-pushed the draft-goerli-migration branch from dccafd5 to 810ebde Compare July 7, 2023 12:36
@Luisfc68 Luisfc68 force-pushed the draft-goerli-migration branch from 810ebde to b05402d Compare July 31, 2023 12:16
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 4 Code Smells

No Coverage information No Coverage information
5.2% 5.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gsoares85 gsoares85 force-pushed the draft-goerli-migration branch from b05402d to 7b3e2b8 Compare July 5, 2024 12:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 5, 2024

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
1 Security Hotspot
0.0% Coverage on New Code
1.5% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsoares85 gsoares85 gsoares85 left review comments

@augustoIOV augustoIOV Awaiting requested review from augustoIOV

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joaoiovlabs @coveralls @gsoares85