Skip to content

Commit

Permalink
fix: linting errors
Browse files Browse the repository at this point in the history
Signed-off-by: Kevin Viglucci <[email protected]>
  • Loading branch information
viglucci committed Jul 29, 2021
1 parent f7bf4ff commit 14302a2
Show file tree
Hide file tree
Showing 5 changed files with 51 additions and 31 deletions.
12 changes: 12 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@

[*]
indent_style = space
indent_size = 2
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.md]
indent_size = 4
trim_trailing_whitespace = false
2 changes: 1 addition & 1 deletion packages/rsocket-core/src/Fragmenter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function isFragmentable(
if (fragmentSize === 0) {
return false;
}

return (
payload.data.byteLength +
(payload.metadata ? payload.metadata.byteLength + Lengths.METADATA : 0) +
Expand Down
30 changes: 14 additions & 16 deletions packages/rsocket-types/src/Common.ts
Original file line number Diff line number Diff line change
@@ -1,21 +1,19 @@
export interface Closeable {
/**
* Close the underlying connection, emitting `onComplete` on the receive()
* Publisher.
*/
close(error?: Error): void;

/**
* Close the underlying connection, emitting `onComplete` on the receive()
* Publisher.
*/
close(error?: Error): void;

/**
*/
get onClose(): Promise<void>;
/**
*/
onClose(): Promise<void>;
}

export interface Availability {

/**
* Returns positive number representing the availability of RSocket requester. Higher is better, 0.0
* means not available.
*/
get availability(): number;
}
/**
* Returns positive number representing the availability of RSocket requester. Higher is better, 0.0
* means not available.
*/
availability(): number;
}
27 changes: 17 additions & 10 deletions packages/rsocket-types/src/RSocket.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
import { Closeable } from "./Common";
import { CancelFrame, ErrorFrame, ExtFrame, PayloadFrame, RequestNFrame } from "./Frames";
import {
CancelFrame,
ErrorFrame,
ExtFrame,
PayloadFrame,
RequestNFrame,
} from "./Frames";
import { FrameHandler, Outbound } from "./Transport";

/**
Expand All @@ -19,7 +25,7 @@ export type SetupPayload = {
resumeToken: Buffer | null | undefined;
data: Buffer | null | undefined;
metadata?: Buffer;
}
};

export interface Cancellable {
cancel(): void;
Expand All @@ -44,18 +50,20 @@ export interface UnidirectionalStream extends Subscription, Extendable {
}

export type StreamConfig = {
outbound: Outbound,
fragmentSize: number,
}
outbound: Outbound;
fragmentSize: number;
};

export interface StreamLifecycleHandler {
handleReady(streamId: number, config: StreamConfig): boolean;
handleReject(error: Error): void;
}

export interface StreamFrameHandler extends FrameHandler {
get streamId(): number;
handle(frame: PayloadFrame | ErrorFrame | CancelFrame | RequestNFrame | ExtFrame): void;
export interface StreamFrameHandler extends FrameHandler {
streamId(): number;
handle(
frame: PayloadFrame | ErrorFrame | CancelFrame | RequestNFrame | ExtFrame
): void;
close(error?: Error): void;
}

Expand All @@ -71,11 +79,10 @@ export interface SocketAcceptor {
}

/**
* A contract providing different interaction models per the [ReactiveSocket protocol]
* A contract providing different interaction models per the [ReactiveSocket protocol]
(https://github.com/ReactiveSocket/reactivesocket/blob/master/Protocol.md).
*/
export interface RSocket extends Closeable {

/**
* Fire and Forget interaction model of `ReactiveSocket`. The returned
* Publisher resolves when the passed `payload` is successfully handled.
Expand Down
11 changes: 7 additions & 4 deletions packages/rsocket-types/src/Transport.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export interface FrameHandler {

export enum FlowControl {
NEXT,
ALL
ALL,
}

export interface FlowControlledFrameHandler {
Expand All @@ -40,9 +40,12 @@ export interface Inbound {
* Represents a network connection with input/output used by a ReactiveSocket to
* send/receive data.
*/
export interface DuplexConnection extends Inbound, Outbound, Closeable, Availability {
}
export interface DuplexConnection
extends Inbound,
Outbound,
Closeable,
Availability {}

export interface ClientTransport {
connect(): Promise<DuplexConnection>
connect(): Promise<DuplexConnection>;
}

0 comments on commit 14302a2

Please sign in to comment.