Set connection status to ERROR when closed due to protocol error (#126) #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amends DuplexConnection#close to accept an optional error indicating that the connection is being closed due to that error. Updates implementations to handle this error and report it to consumers. Updates RSocketMachine to pass protocol-level connection errors to close Adds/updates tests to check for handling this parameter Signed-off-by: Stephen Cohen <[email protected]>
ada-waffles
force-pushed
the
bugfix/connection-error-status
branch
from
6254847 to
a03b173
Compare
|
Hi @duke9509! Thanks for filing #126 and for providing this PR. While I'm not able to offer a timeframe at the moment, we'll do our best to get this reviewed. Thanks again! |
viglucci
reviewed
May 15, 2021
There was a problem hiding this comment.
Overall this seems pretty tame and a good approach, however, I did have two questions. I would be interested to hear any thoughts from those more experienced with the project, such as @OlegDokuka.
viglucci
reviewed
May 15, 2021
|
My questions were answered and everything turned out to be non-issues. I pinged some maintainers with write permissions to hopefully take a look and give a final approval/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set connection status to ERROR when closed due to protocol error
Motivation:
Addresses #126
Modifications:
DuplexConnection#closeto accept an optional error indicating that the connection is being closed due to that errorRSocketMachineto pass protocol-level connection errors to closeResult:
Protocol-level errors will forward the error through the new
errorparameter inDuplexConnection#close, resulting inERRORstatus instead ofCLOSED