Fixes, cleanup dead code, static save option and flexible unitOfWork injection #14
Conversation
| @@ -9,7 +9,7 @@ | |||
| "default": true | |||
| }, | |||
| { | |||
| "path": "sfdx-source/apex-domainbuilder-samplecode", | |||
| "path": "sfdx-source/apex-domainbuilder-sample", | |||
| @@ -1,3 +1,4 @@ | |||
| @IsTest | |||
| public class Random { | |||
There was a problem hiding this comment.
This class did not have almost coverage and is only used within @istest classes, hence adding it too
| @@ -3,7 +3,7 @@ public class Account_t extends DomainBuilder { | |||
|
|
|||
| public Account_t() { | |||
| super(Account.SObjectType); | |||
|
|
|||
There was a problem hiding this comment.
invisible whitespace removal
| @@ -1,10 +1,30 @@ | |||
| @IsTest | |||
| public class DomainBuilder_Test { | |||
| @IsTest | |||
| private static void staticHappyPath() { | |||
There was a problem hiding this comment.
test method to demostrate the possibility of calling the save() static method, similar to persist() but without requiring an instance, since it only actually operates on static variables it is logically meaningful.
|
|
||
| @IsTest | ||
| private static void happyPath() { | ||
|
|
||
| Contact_t joe = new Contact_t().first('Ron').last('Harris'); | ||
| Contact_t joe = new Contact_t().first('Joe').last('Harris'); |
There was a problem hiding this comment.
the variable name is joe, so firstName should not be "Ron"
| System.assertEquals(6, Limits.getDmlRows()); | ||
|
|
||
| // Verify | ||
| System.assertEquals(5, Limits.getDmlRows()); |
There was a problem hiding this comment.
This assertion was throwing an error because only 5 DML rows are consumed, not 6. SetSavePoint counts against DML Statements, but not against DML Rows. Added extra assert with comments for demostration
| @@ -3,36 +3,31 @@ public abstract class DomainBuilder { | |||
| private static DirectedGraph graph = new DirectedGraph(); | |||
| private static Set<DomainBuilder> objects = new Set<DomainBuilder>(); | |||
|
|
|||
| private Boolean isSetupObject; | |||
There was a problem hiding this comment.
remove unused related dead code
| // PUBLIC | ||
|
|
||
| public SObject persist() { | ||
| fflib_SObjectUnitOfWork uow = unitOfWork(); | ||
| public static void save() { |
There was a problem hiding this comment.
provide possible static save() call
| } | ||
|
|
||
| public SObject persist(fflib_SObjectUnitOfWork.IDML dml) { |
There was a problem hiding this comment.
allow injection of custom implementation of UnitOfWork interface
No description provided.