Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Fix issues on Ruby 3.4.0-preview1 #1471

Merged
merged 4 commits into from
Jul 14, 2024
Merged

Fix issues on Ruby 3.4.0-preview1 #1471

merged 4 commits into from
Jul 14, 2024

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Jul 14, 2024

Continuing a theme from other PRs... fix some of the issues with the build on Ruby 3.4:

  • Add block parameters to remove warnings
  • Prevent string mutation with << in favour of +=
  • Fix output assertion for Ruby 3.4
  • Prevent force_encoding warning with string literals by using dup

@JonRowe JonRowe merged commit 4d0be3e into main Jul 14, 2024
29 of 30 checks passed
@JonRowe JonRowe deleted the fix-ruby-head branch July 14, 2024 22:13
JonRowe added a commit that referenced this pull request Jul 15, 2024
Fix issues on Ruby 3.4.0-preview1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant