Merge pull request #2711 from rspec/fix-leak-of-execution-context

Fix leak of execution context between specs

lib/rspec/rails/example/rails_example_group.rb

@@ -2,6 +2,10 @@
 # suite and ammeter.
 require 'rspec/rails/matchers'
 
+if ::Rails::VERSION::MAJOR >= 7
+  require 'active_support/execution_context/test_helper'
+end
+
 module RSpec
   module Rails
     # @api public
@@ -12,7 +16,10 @@ module RailsExampleGroup
       include RSpec::Rails::MinitestLifecycleAdapter
       include RSpec::Rails::MinitestAssertionAdapter
       include RSpec::Rails::FixtureSupport
-      include RSpec::Rails::TaggedLoggingAdapter if ::Rails::VERSION::MAJOR >= 7
+      if ::Rails::VERSION::MAJOR >= 7
+        include RSpec::Rails::TaggedLoggingAdapter
+        include ActiveSupport::ExecutionContext::TestHelper
+      end
     end
   end
 end

spec/rspec/rails/example/rails_example_group_spec.rb

@@ -5,5 +5,32 @@ module RSpec::Rails
         expect(described_class.private_instance_methods).to include(:tagged_logger)
       end
     end
+
+    it 'does not leak context between example groups', if: ::Rails::VERSION::MAJOR >= 7 do
+      groups =
+        [
+          RSpec::Core::ExampleGroup.describe("A group") do
+            include RSpec::Rails::RailsExampleGroup
+            specify { expect(ActiveSupport::ExecutionContext.to_h).to eq({}) }
+          end,
+          RSpec::Core::ExampleGroup.describe("A controller group", type: :controller) do
+            specify do
+              Rails.error.set_context(foo: "bar")
+              expect(ActiveSupport::ExecutionContext.to_h).to eq(foo: "bar")
+            end
+          end,
+          RSpec::Core::ExampleGroup.describe("Another group") do
+            include RSpec::Rails::RailsExampleGroup
+            specify { expect(ActiveSupport::ExecutionContext.to_h).to eq({}) }
+          end
+        ]
+
+      results =
+        groups.map do |group|
+          group.run(failure_reporter) ? true : failure_reporter.exceptions
+        end
+
+      expect(results).to all be true
+    end
   end
 end