Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 1.2, update CLDR v43 #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

version 1.2, update CLDR v43 #2

wants to merge 1 commit into from

Conversation

zhu
Copy link

@zhu zhu commented Jun 7, 2023

update CLDR v43

@georgkrause
Copy link

@zhu Hi! I saw your work, its great! @rspeer allowed me to release new versions to pypi, so I am looking into updating it. I'd like to pick up your changes, however I noticed CLDR v44 got released and I wanted to update as well. However, I am not quite sure how to do it. Maybe you can leave me some pointers what you did to update to v43?

@georgkrause
Copy link

@zhu I used your work to learn how to update and updated to 44.1 in georgkrause#6

I also picked your adjustments to build_data.py in b4283be and preserved your authorship (Let me know if you have any issues with this)

I also documented the process in the README to make it easier in the future.

I'd appreciate a review!

@zhu
Copy link
Author

zhu commented Feb 29, 2024

@zhu I used your work to learn how to update and updated to 44.1 in georgkrause#6

I also picked your adjustments to build_data.py in b4283be and preserved your authorship (Let me know if you have any issues with this)

I also documented the process in the README to make it easier in the future.

I'd appreciate a review!

Hi! It's OK. Thanks.

@zhu
Copy link
Author

zhu commented Feb 29, 2024

@zhu Hi! I saw your work, its great! @rspeer allowed me to release new versions to pypi, so I am looking into updating it. I'd like to pick up your changes, however I noticed CLDR v44 got released and I wanted to update as well. However, I am not quite sure how to do it. Maybe you can leave me some pointers what you did to update to v43?

Do you have the permission to update the langcodes? I have a pull request there. rspeer/langcodes#61

@georgkrause
Copy link

@zhu I do have the permissions to update the package on PyPi, however I cannot write to the repository. I am going to take care for the project next, if you want to help me you can file the PR to https://github.com/georgkrause/langcodes as well

@zhu
Copy link
Author

zhu commented Mar 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants