-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to weight viapoint orientations #109
Open
zerodamage
wants to merge
5
commits into
rst-tu-dortmund:kinetic-devel
Choose a base branch
from
zerodamage:origin/master
base: kinetic-devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6ac179f
First attempt at via point poses
zerodamage 068f597
modified: include/teb_local_planner/visualization.h
zerodamage b7d27ca
Readd test_optim_node to CMakeLists
zerodamage 4dcca96
Readd test_optim_node
zerodamage 6e83d07
Fix test_optim_node for new PoseSE2
zerodamage File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -664,7 +664,7 @@ void TebOptimalPlanner::AddEdgesDynamicObstacles(double weight_multiplier) | |
|
||
void TebOptimalPlanner::AddEdgesViaPoints() | ||
{ | ||
if (cfg_->optim.weight_viapoint==0 || via_points_==NULL || via_points_->empty() ) | ||
if ((cfg_->optim.weight_viapoint==0 && cfg_->optim.weight_viapoint_orientation==0)|| via_points_==NULL || via_points_->empty() ) | ||
return; // if weight equals zero skip adding edges! | ||
|
||
int start_pose_idx = 0; | ||
|
@@ -675,8 +675,9 @@ void TebOptimalPlanner::AddEdgesViaPoints() | |
|
||
for (ViaPointContainer::const_iterator vp_it = via_points_->begin(); vp_it != via_points_->end(); ++vp_it) | ||
{ | ||
PoseSE2 temp = *vp_it; | ||
|
||
int index = teb_.findClosestTrajectoryPose(*vp_it, NULL, start_pose_idx); | ||
int index = teb_.findClosestTrajectoryPose(temp.position(), NULL, start_pose_idx); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't know if this could be done in a more optimal code style |
||
if (cfg_->trajectory.via_points_ordered) | ||
start_pose_idx = index+2; // skip a point to have a DOF inbetween for further via-points | ||
|
||
|
@@ -696,9 +697,12 @@ void TebOptimalPlanner::AddEdgesViaPoints() | |
continue; // skip via points really close or behind the current robot pose | ||
} | ||
} | ||
Eigen::Matrix<double,1,1> information; | ||
information.fill(cfg_->optim.weight_viapoint); | ||
|
||
Eigen::Matrix<double,2,2> information; | ||
information(0,0) = cfg_->optim.weight_viapoint; | ||
information(1,1) = cfg_->optim.weight_viapoint_orientation; | ||
information(0,1) = information(1,0) = 0; | ||
|
||
EdgeViaPoint* edge_viapoint = new EdgeViaPoint; | ||
edge_viapoint->setVertex(0,teb_.PoseVertex(index)); | ||
edge_viapoint->setInformation(information); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs some work...