Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the full PWB version docker tag #491

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

cm421
Copy link
Contributor

@cm421 cm421 commented May 2, 2024

The tag for PWB image rstudio/rstudio-workbench:ubuntu2204-2024.04.0 doesn't exist on docker hub for some reason, which causes problems because that's the tag used in PWB's helm chart.

While platform team investigates why that tag wasn't created, we can use rstudio/rstudio-workbench:ubuntu2204-024.04.0-735.pro3 instead

@cm421 cm421 requested review from colearendt and atheriel as code owners May 2, 2024 21:26
@cm421 cm421 requested a review from tnederlof May 2, 2024 21:26
@kfeinauer
Copy link
Contributor

@cm421 Need to bump the chart version before merge.

@tnederlof
Copy link
Contributor

tnederlof commented May 2, 2024

I think those annotations are only for artifacthub.io, the values in the values.yaml file under image and session.image are what drive the images pulled by default. The chart is set up to take the app version + tagPrefix and pull automatically, to override we would need to set the following two tags with ubuntu2204-2024.04.0-735.pro3:

image.tag


session.image.tag

@cm421
Copy link
Contributor Author

cm421 commented May 3, 2024

So changing appVersion: 2024.04.0 to appVersion: 2024.04.0+735.pro3 in charts/rstudio-workbench/Chart.yaml should set the default tag as well?

Anyone with more helm experience know if changing that will affect other areas as well?

@tnederlof
Copy link
Contributor

So changing appVersion: 2024.04.0 to appVersion: 2024.04.0+735.pro3 in charts/rstudio-workbench/Chart.yaml should set the default tag as well?

Anyone with more helm experience know if changing that will affect other areas as well?

It would apply to the image, but it looks like the variable is used in a couple of spots. Since all the helm charts are consistent across products in this area, it would be nice to leave it as is if the image can be corrected on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants