Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect: add support for RHEL distributions to startup script #502

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented May 10, 2024

Same as #453

@dbkegley
Copy link
Contributor

Looks good! This will need a chart version bump and then I think it's good to merge

@pat-s
Copy link
Contributor Author

pat-s commented Dec 20, 2024

@dbkegley Should be good to go.

Somewhat confusing that CI for forked PRs always fails due to missing write permissions on the fork by the CI bot.

@dbkegley
Copy link
Contributor

@jforest How should we address contributions from forks for this repo given that CI doesn't run? I can't override these merges anymore since the permissions have changed.

@pat-s
Copy link
Contributor Author

pat-s commented Jan 16, 2025

@dbkegley Can we get this merged? Would like to use the upstream chart again with some RHEL-based images :)

@dbkegley
Copy link
Contributor

@pat-s your chart bump was overwritten by a version bump on main, sorry about that.

@jforest bumping this PR, I'm still not sure what the process is for PRs from forks, do you have any guidance here? I can recreate this one myself if that's the preferred route for the near term

@jforest
Copy link
Contributor

jforest commented Jan 16, 2025

@pat-s your chart bump was overwritten by a version bump on main, sorry about that.

@jforest bumping this PR, I'm still not sure what the process is for PRs from forks, do you have any guidance here? I can recreate this one myself if that's the preferred route for the near term

Sorry @dbkegley I missed this while out on vacation. For now, I think you'll have to recreate this in order for tests to run, we do not currently have a way for forks to run the tests properly. because they don't have access to our secrets

@dbkegley
Copy link
Contributor

No probs! Thanks @jforest

@pat-s I'm OOO starting tomorrow for the long weekend but I'll take this one over and create a PR for it next week to get this merged and released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants