Fixed edge case where n_versions = 0 (#838)

* Fixed edge case where n_versions = 0 * Update NEWS --------- Co-authored-by: Julia Silge <[email protected]>
rstudio · Aug 27, 2024 · 58082a3 · 58082a3
1 parent 2edcccb
commit 58082a3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -12,6 +12,8 @@
 
 * Fixed a bug in handling folders with duplicate names for Google Drive (#819, @UchidaMizuki)
 
+* Fixed how previously deleted pin versions are detected (#838, @MichalLauer)
+
 # pins 1.3.0
 
 ## Breaking changes

diff --git a/R/pin_versions.R b/R/pin_versions.R
@@ -157,19 +157,23 @@ version_from_path <- function(x) {
 }
 
 version_setup <- function(board, name, new_version, versioned = NULL, call = caller_env()) {
+
+  n_versions <- 0
+
   if (pin_exists(board, name)) {
     versions <- pin_versions(board, name)
-    old_version <- versions$version[[1]]
     n_versions <- nrow(versions)
-    if (old_version == new_version) {
-      cli::cli_abort(c(
-        "The new version {.val {new_version}} is the same as the most recent version.",
-        i = "Did you try to create a new version with the same timestamp as the last version?"
-      ),
-      call = call)
+
+    if (n_versions > 0) {
+      old_version <- versions$version[[1]]
+      if (old_version == new_version) {
+        cli::cli_abort(c(
+          "The new version {.val {new_version}} is the same as the most recent version.",
+          i = "Did you try to create a new version with the same timestamp as the last version?"
+        ),
+        call = call)
+      }
     }
-  } else {
-    n_versions <- 0
   }
 
   versioned <- versioned %||% if (n_versions > 1) TRUE else board$versioned
@@ -184,4 +188,4 @@ version_setup <- function(board, name, new_version, versioned = NULL, call = cal
   }
 
   new_version
-}
+}