Fix how board_gdrive()
uses dribble components
#782
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #781
When I first put together the support for the Google Drive board, I did not pay enough attention to what is guaranteed to come in a dribble object:
https://googledrive.tidyverse.org/reference/dribble.html
This PR addresses this more holistically than #780, throughout all the methods. I don't think I want to change my general testing strategy, but I did just locally run through this (after running
devtools::load_all()
):All these tests pass and I expect this to now work much better.