Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC 1.2.2 #784

Merged
merged 5 commits into from
Sep 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: pins
Title: Pin, Discover and Share Resources
Version: 1.2.1.9000
Version: 1.2.2
Authors@R: c(
person("Julia", "Silge", , "[email protected]", role = c("cre", "aut"),
comment = c(ORCID = "0000-0002-3671-836X")),
Expand Down
3 changes: 1 addition & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# pins (development version)
# pins 1.2.2

* Fixed how dots are checked in `pin_write()` to make user-facing messages more
clear (#770).
Expand All @@ -9,7 +9,6 @@

* Fixed how `board_gdrive()` handles dribble objects (#780, @gorkang and #782).


# pins 1.2.1

* New environment variable `PINS_CACHE_DIR` controls the location of the
Expand Down
2 changes: 1 addition & 1 deletion R/board_url.R
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
#' ```
#'
#' @export
#' @examples
#' @examplesIf !pins:::is_cran_check()
#' github_raw <- function(x) paste0("https://raw.githubusercontent.com/", x)
#'
#' ## with a named vector of URLs to specific pins:
Expand Down
13 changes: 13 additions & 0 deletions R/utils.R
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,16 @@ null_if_na <- function(x) {
is_rcmd_check <- function() {
Sys.getenv("_R_CHECK_PACKAGE_NAME_", "") != ""
}

# adapted from ps:::is_cran_check()
# nocov start

is_cran_check <- function () {
if (identical(Sys.getenv("NOT_CRAN"), "true")) {
FALSE
} else {
Sys.getenv("_R_CHECK_PACKAGE_NAME_", "") != ""
}
}

#nocov end
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ board <- board_temp()
board
#> Pin board <pins_board_folder>
#> Path:
#> '/var/folders/07/0sps_qnd3qd7fdj3cq9j8pqw0000gn/T/RtmpfnLq46/pins-16f285b5dde39'
#> '/var/folders/hv/hzsmmyk9393_m7q3nscx1slc0000gn/T/Rtmp4Z1lsA/pins-8a413b4b4478'
#> Cache size: 0
```

Expand All @@ -73,7 +73,7 @@ arguments: the board to pin to, an object, and a name:
``` r
board %>% pin_write(head(mtcars), "mtcars")
#> Guessing `type = 'rds'`
#> Creating new version '20230816T005558Z-8df40'
#> Creating new version '20230908T204205Z-a800d'
#> Writing to pin 'mtcars'
```

Expand Down
3 changes: 2 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## revdepcheck results

We checked 3 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
We checked 4 reverse dependencies (3 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages

3 changes: 2 additions & 1 deletion man/board_url.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion revdep/cran.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## revdepcheck results

We checked 3 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
We checked 4 reverse dependencies (3 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/test-board_url.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
skip_if_not_installed("webfakes")
skip_on_cran()

httpbin <- local_httpbin_app()
httpbin_port <- httpbin$get_port()
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/test-pin.R
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
skip_if_not_installed("filelock")
skip_if_not_installed("webfakes")
skip_on_cran()

httpbin <- local_httpbin_app()
httpbin_port <- httpbin$get_port()
Expand Down
Loading