Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix folder creation by gdrive_mkdir() #819

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Fix folder creation by gdrive_mkdir() #819

merged 2 commits into from
Jan 13, 2024

Conversation

UchidaMizuki
Copy link
Contributor

Closes #818.

This PR changes to use drive_id instead of folder name when creating folders in gdrive.
This change resolves the issue of creating folders due to duplicate folder names.

This change resolves #818 locally.

library(pins)
library(googledrive)
drive_auth("[email protected]")

board <- board_gdrive(as_id("11wUPQi82qsXArmMeu3ENdUK_QvdU1rMv"))
board |> 
  pin_write(iris, "iris")
#> Guessing `type = 'rds'`
#> Creating new version '20240111T113330Z-d16b7'
#> Writing to pin 'iris'

Created on 2024-01-11 with reprex v2.0.2

@UchidaMizuki UchidaMizuki changed the title Fix folder creation `gdrive_mkdir()' (#818) Fix folder creation `gdrive_mkdir()' Jan 11, 2024
@UchidaMizuki UchidaMizuki changed the title Fix folder creation `gdrive_mkdir()' Fix folder creation by `gdrive_mkdir()' Jan 11, 2024
@UchidaMizuki UchidaMizuki changed the title Fix folder creation by `gdrive_mkdir()' Fix folder creation by gdrive_mkdir() Jan 11, 2024
juliasilge
juliasilge approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @UchidaMizuki! 🙌

I tested this out locally with my own Google Drive and everything appears to be working great.

@juliasilge juliasilge merged commit b8827ac into rstudio:main Jan 13, 2024
14 checks passed
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juliasilge juliasilge juliasilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pin_write error due to duplicate folder name in gdrive
2 participants
@UchidaMizuki @juliasilge