Revert change + add skip for Old Windows

R/write_testthat_file.R

@@ -681,13 +681,19 @@ pb_write_file <- function(
 
   on.exit(close(file_connection))
 
-  # We use Unix to write testthat file
-  lines <- gsub("\r?\n", "\n", lines)
+  # Obtain the appropriate line ending based on the platform
+  if (.Platform$OS.type == "windows") {
+    line_ending <- "\r\n"
+  } else {
+    line_ending <- "\n"
+  }
+
+  lines <- gsub("\r?\n", line_ending, lines)
 
   writeLines(
     text = enc2utf8(lines),
     con = file_connection,
-    sep = "\n",
+    sep = line_ending,
     useBytes = TRUE
   )
 

tests/testthat/helper.R

@@ -4,3 +4,8 @@ expect_equal_unlist <- function(object, expected, ...) {
     expected
   )
 }
+
+skip_if_not_utf8 <- function() {
+  # likely on Windows for R < 4.2
+  skip_if_not(l10n_info()$`UTF-8`)
+}

tests/testthat/test-draft_validation.R

@@ -1,3 +1,4 @@
+skip_on_cran()
 work_path <- "./generated_r_files"
 
 if (fs::dir_exists(path = work_path)) {
@@ -90,7 +91,7 @@ test_that("draft validations for data tables can be generated", {
 })
 
 test_that("draft validations for data tables can be generated in different languages", {
-
+  skip_if_not_utf8()
   write_draft_snapshot_test(dataset = pointblank::small_table, filename = "st_en", lang = "en")
   write_draft_snapshot_test(dataset = pointblank::small_table, filename = "st_fr", lang = "fr")
   write_draft_snapshot_test(dataset = pointblank::small_table, filename = "st_de", lang = "de")