-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild translation table + support ordered factor in scan_data #580
Conversation
…n_data(ggplot2::diamonds[1:100,], lang = "fr", sections = "v") would show tbl_df class for column.
…n't break anything
@rich-iannone Ready for review! With #581, I convinced myself that translations currently don't work correctly on Windows R < 4.2. Therefore, I am more confident with my changes here.
(Edit: sorry for closing / reopening. I accidently clicked) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is really great, thanks again! |
This example was motivated by this example
Before:
Also the link at the bottom was a dead link:
This PR:
(notice that factor shows up) and FR translation is correct.
Links updated
The initial reason why I pursued this was the link, but the translations + support for ordered factor is a good addition!