Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache engine for
reticulate
usingdill
#1210base: main
Are you sure you want to change the base?
Cache engine for
reticulate
usingdill
#1210Changes from 9 commits
228624b
b52ecaa
c345ce2
ff39889
8e07779
638a4e7
9753870
02c1771
dbebab3
bd29f84
f8497a0
fe4cd9f
5d6f7a7
a33ed39
266463c
445a5ca
c6a88ad
975c1b0
401b1ba
62c77d8
f487b52
cb9ee1f
7d4eeec
395627e
55d1e03
d43b593
f354f60
38ef3ce
79b9732
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this have side effects (basically meaning the
r
object is no longer visible after this code is run)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is run at the end of a knitir block, and currently the
r
object in injected again in the Python namespace at the beginning of the next block. An alternative to putting this object directly in the user's__main__
namespace would be to add it to__builtins__
. This would bring another advantage: the user could then create anr
global variable without overwriting it, it would only be masked. Thendel r
would unmask it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't put the
r
object in__builtins__
, but I did put the "R object class" in__builtins__
. Ther
object is not removed before saving the cache anymore, it's just ignored. However, my previous suggestion is still open for discussion.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.