Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify capturing R dependencies message #1099

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

statik
Copy link
Contributor

@statik statik commented Aug 28, 2024

This simplification is based on feedback from @jennybc @gadenbuie on Connect Cloud.

don't mention renv as this is confusing

Signed-off-by: Elliot Murphy <[email protected]>
@gadenbuie
Copy link
Member

For some context, this is the discussion we had about the use of renv in the shinylive package: posit-dev/r-shinylive#84

We decided that including "with renv" or even mentioning that we "find which packages are being used via renv" creates confusion about whether or not the user needs to be using renv for their project, or have a lock file, etc. In the end we decided that when using renv only for dependency discovery, it causes less confusion to simply say we "automatically detect package dependencies" and leave out the "with renv".

@aronatkins aronatkins merged commit 2fe8fde into main Aug 30, 2024
11 checks passed
@aronatkins aronatkins deleted the simplify-dependency-message branch August 30, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants