Feature/add deployment timestamp #1100
Conversation
| @@ -164,6 +166,7 @@ writeDeploymentRecord <- function(record, filePath) { | |||
| addToDeploymentHistory <- function(appPath, deploymentRecord) { | |||
| # add the appPath to the deploymentRecord | |||
There was a problem hiding this comment.
deploymentFields needs updating.
| @@ -147,6 +148,7 @@ deploymentRecord <- function(name, | |||
| appId = appId %||% "", | |||
| bundleId = bundleId %||% "", | |||
| url = url %||% "", | |||
| when = when %||% as.numeric(as.POSIXct(Sys.time())), | |||
There was a problem hiding this comment.
Please add a test confirming that we read the same when data that was written.
|
Here's the news bullet for context:
IMO it's not worth adding back just for that display in workbench; if it wants that metadata it should talk to the connect API. |
|
🤔 In that case I'll just remove the display field from Workbench until we work on a larger feature to obtain the history information from the connect API (which I haven't looked into yet) rather than reading a file -- if we're getting one field from an API we might as well get all of them. The Workbench code predates any context of mine, so I assume it was probably the easiest short-term "integration" since the I'll open up a feature request for this, since I don't think it will be as trivial as a bug fix. |
See: https://github.com/rstudio/rstudio-pro/issues/5597
We have this provisioning on the Workbench homepage to display the timestamp (unix epoch in seconds) for when you recently published something via rsconnect. For whatever reason, there are no timestamps added to the history entries in the
history.dcffile that Workbench reads. This fixes that missing timestamp without requiring any changes on the Workbench side.