Make bundlePackages() more robust #922
Conversation
This ensures that we work better with both dev renv and with recommended packages that are bundled with R itself.
| deps$description <- lapply( | ||
| deps$Package, | ||
| package_record, | ||
| # Ensure we fall back to system libraries |
There was a problem hiding this comment.
Aside: In an renv project, this is the set of libraries managed by renv.. This would have made yesterday's renv changes unnecessary, as the incoming library within the deploy pane included the two renv paths and my system library.
In other words: When deploying an renv project, the renv::restore run by rsconnect might be unnecessary since the incoming .libPaths() should already have all the dependencies available.
Do you recall why we added the restore?
There was a problem hiding this comment.
It ensures that we get the DESCRIPTION for the versions declared in your lockfile, rather than the versions you currently have installed in your library.
But maybe we should check renv::status()$sychronised and only restore if that's FALSE? That seems like a nice optimisation.
There was a problem hiding this comment.
Feels like that optimization can come later. Feels like we can just merge as-is, then.
This ensures that we work better with both dev renv and with recommended packages that are bundled with R itself.